From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 8/8] staging: rtl8188eu: remove variable from rtl8188eu_xmit_tasklet()
Date: Thu, 22 Nov 2018 14:52:18 +0100 [thread overview]
Message-ID: <20181122135218.1703-8-straube.linux@gmail.com> (raw)
In-Reply-To: <20181122135218.1703-1-straube.linux@gmail.com>
The local variable ret is only used to test the return value of the
call to rtl8188eu_xmitframe_complete(). Use the function directly in
the if test and remove the variable ret.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
index 9a732adbf1b1..7dc7028c1cd5 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
@@ -796,7 +796,6 @@ void rtl8188eu_recv_tasklet(void *priv)
void rtl8188eu_xmit_tasklet(void *priv)
{
- int ret = false;
struct adapter *adapt = priv;
struct xmit_priv *pxmitpriv = &adapt->xmitpriv;
@@ -811,9 +810,7 @@ void rtl8188eu_xmit_tasklet(void *priv)
break;
}
- ret = rtl8188eu_xmitframe_complete(adapt, pxmitpriv);
-
- if (!ret)
+ if (!rtl8188eu_xmitframe_complete(adapt, pxmitpriv))
break;
}
}
--
2.19.1
prev parent reply other threads:[~2018-11-22 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 13:52 [PATCH 1/8] staging: rtl8188eu: use __func__ in usb_ops_linux.c Michael Straube
2018-11-22 13:52 ` [PATCH 2/8] staging: rtl8188eu: cleanup line ending with a '(' Michael Straube
2018-11-22 13:52 ` [PATCH 3/8] staging: rtl8188eu: remove braces from single if else statement Michael Straube
2018-11-22 13:52 ` [PATCH 4/8] staging: rtl8188eu: correct spelling mistake in a comment Michael Straube
2018-11-22 13:52 ` [PATCH 5/8] staging: rtl8188eu: remove unnecessary parentheses Michael Straube
2018-11-22 13:52 ` [PATCH 6/8] staging: rtl8188eu: add spaces around '>>' and '&' Michael Straube
2018-11-22 13:52 ` [PATCH 7/8] staging: rtl8188eu: cleanup declarations in usb_ops_linux.c Michael Straube
2018-11-22 13:52 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122135218.1703-8-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.