From: Phillip Potter <phil@philpotter.co.uk>
To: Jan Kara <jack@suse.cz>
Cc: jack@suse.com, amir73il@gmail.com, viro@zeniv.linux.org.uk,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH v4 04/09] ext2: use common file type conversion
Date: Thu, 22 Nov 2018 14:42:00 +0000 [thread overview]
Message-ID: <20181122144200.GA26035@pathfinder> (raw)
In-Reply-To: <20181122114023.GE9840@quack2.suse.cz>
On Thu, Nov 22, 2018 at 12:40:23PM +0100, Jan Kara wrote:
> On Wed 21-11-18 19:06:53, Phillip Potter wrote:
> > Deduplicate the ext2 file type conversion implementation - file systems
> > that use the same file types as defined by POSIX do not need to define
> > their own versions and can use the common helper functions decared in
> > fs_types.h and implemented in fs_types.c
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
Dear Jan,
Thank you for reviewing this patch, and for all the others too. Much
appreciated.
Regards,
Phil
prev parent reply other threads:[~2018-11-23 1:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 19:06 [RFC][PATCH v4 04/09] ext2: use common file type conversion Phillip Potter
2018-11-22 11:40 ` Jan Kara
2018-11-22 12:47 ` Amir Goldstein
2018-11-27 8:56 ` Jan Kara
2018-11-22 14:42 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122144200.GA26035@pathfinder \
--to=phil@philpotter.co.uk \
--cc=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.