From: Kevin Wolf <kwolf@redhat.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: qemu-block@nongnu.org, Keith Busch <keith.busch@intel.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stephen Bates <stephen@eideticom.com>
Subject: Re: [Qemu-devel] [PATCH] hw/block/nvme: fix bug with PCI IRQ pins on teardown
Date: Thu, 22 Nov 2018 16:24:40 +0100 [thread overview]
Message-ID: <20181122152440.GE31879@linux.fritz.box> (raw)
In-Reply-To: <20181121181013.4983-1-logang@deltatee.com>
Am 21.11.2018 um 19:10 hat Logan Gunthorpe geschrieben:
> When the submission and completion queues are being torn down
> the IRQ will be asserted for the completion queue when the
> submsission queue is deleted. Then when the completion queue
> is deleted it stays asserted. Thus, on systems that do
> not use MSI, no further interrupts can be triggered on the host.
>
> Linux sees this as a long delay when unbinding the nvme device.
> Eventually the interrupt timeout occurs and it continues.
>
> To fix this we ensure we deassert the IRQ for a CQ when it is
> deleted.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2018-11-22 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 18:10 [Qemu-devel] [PATCH] hw/block/nvme: fix bug with PCI IRQ pins on teardown Logan Gunthorpe
2018-11-22 15:24 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122152440.GE31879@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=keith.busch@intel.com \
--cc=logang@deltatee.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stephen@eideticom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.