From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp893245wrt; Thu, 22 Nov 2018 08:27:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/X99Nc4FVuXJNpbLvXSudE7Ivu00ev2K1kni2knFZc1nTewYF/HJ40/pw/v4U4c9X6E9+7s X-Received: by 2002:a25:4457:: with SMTP id r84-v6mr1779164yba.192.1542904034912; Thu, 22 Nov 2018 08:27:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542904034; cv=none; d=google.com; s=arc-20160816; b=gCyuIhX6dj670rEe7HzxBnfXkzRkIONdTdANs8zqVi1IuSpZZQfp9vhmkdqsRbTAMR R9ofzd+NLqefdMK5F4UPTSsf0OXTMKEuoX69+SZJaGq2Ddn5kOmwYoLPCy29d0bTqo8C UsYy4WRUQy+/hy1oyARHr6JgXL+/6HuHBXdRc6/IoZrNbPWWgbMWuUgxMd1hFaTFEeGA Ualk5EbAIIZkL+1z1kToPcIt9jIo5tBVgO1OfhT/dEa7gf8hScIq28jXyA0ffn/lasXM QpMrzOuEngndbebmMSulQaJii8/gWgDPMaAYqi/Sh2oxYo388vTvYun3ztOvY+7ANKRB aSwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:to:from:date; bh=K/mpK4iO+IVTKjvpGZHfx/mTq1DQKMMjTiBnxl1+IbY=; b=GUkhObbBTrOhphdHWrovwtIR6C5yJliG4Xomd2xz2jiuq2EnkqWw+TIvYfaI12s09R C3Z76OsteAW94ALAXh+pJJxHoWE7W7axmPXQQgb6qhZQAZQ5PIHKEUfN/2q1J4/3SuVh Jx+PQgl/CWk2xaXpopqVj137NstdqKdbZ65iI5vvmne5ik/yigGnM8fKaXKDHNcimLMN oVBVnb7D3nZhRGP1EeuNglDZk9216euFEKjxr/wbuFHFZAW9/8SdgT+t1nOGbQ6uTtEU HWGEwA0KdSHrctu0IQuWpCE/sEqjURcmiCPK/YxVKsQDdVs0zS5VDjLfi1ZeDpJcscIq RBNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x18-v6si29476624ybq.488.2018.11.22.08.27.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 22 Nov 2018 08:27:14 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:47576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gProv-0003N6-Qb for alex.bennee@linaro.org; Thu, 22 Nov 2018 11:27:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gProo-0003Ms-GW for qemu-arm@nongnu.org; Thu, 22 Nov 2018 11:27:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gProj-0007h1-Q8 for qemu-arm@nongnu.org; Thu, 22 Nov 2018 11:27:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40762) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gProj-0007g7-BP; Thu, 22 Nov 2018 11:27:01 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F884308FC5C; Thu, 22 Nov 2018 16:26:59 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id B58ED60920; Thu, 22 Nov 2018 16:26:53 +0000 (UTC) Date: Thu, 22 Nov 2018 17:26:52 +0100 From: Igor Mammedov To: Samuel Ortiz Message-ID: <20181122172652.6b02aef6@redhat.com> In-Reply-To: <20181121144211.GE4426@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-6-sameo@linux.intel.com> <20181108151623.4de26ecb@redhat.com> <20181121144211.GE4426@caravaggio> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 22 Nov 2018 16:26:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: yw6SBwVutC7m On Wed, 21 Nov 2018 15:42:11 +0100 Samuel Ortiz wrote: > Hi Igor, > > On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:28 +0100 > > Samuel Ortiz wrote: > > > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > > Description Table). RSDT only allow for 32-bit addressses and have thus > > > been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and > > > no longer RSDTs, although RSDTs are still supported for backward > > > compatibility. > > > > > > Since version 2.0, RSDPs should add an extended checksum, a complete table > > > length and a version field to the table. > > > > This patch re-implements what arm/virt board already does > > and fixes checksum bug in the later and at the same time > > without a user (within the patch). > > > > I'd suggest redo it a way similar to FADT refactoring > > patch 1: fix checksum bug in virt/arm > > patch 2: update reference tables in test > > patch 3: introduce AcpiRsdpData similar to commit 937d1b587 > > (both arm and x86) wich stores all data in hos byte order > > patch 4: convert arm's impl. to build_append_int_noprefix() API (commit 5d7a334f7) > > > > ... move out to aml-build.c > > patch 5: reuse generalized arm's build_rsdp() for x86, dropping x86 specific one > > amending it to generate rev1 variant defined by revision in AcpiRsdpData > > (commit dd1b2037a) > I agree patches #1, #2 and #5 make sense. 3 and 4 as well, but here > you're asking about something that's out of scope of the current serie. /me guilty of that, but I have excuses for doing so: * that's the only way to get rid of legacy approach given limited resources. So task goes to whomever touches old code. /others and me included/ I'd be glad if someone would volunteer and do clean ups but in absence of such, the victim is interested party. * contributor to ACPI part learns how to use preferred approach, makes code more robust and clear as it's not possible to make endianness mistakes, very simple to review and notice mistakes as end result practically matches row by row a table described in spec. * there could be exceptions, like acpi/nvdimm.c also contributed by Intel whole file written in legacy style (it probably started before I started enforcing conversions, anyways it's late now and should be done as whole), or odd fixes to existing tables, or too complex case. (depending on case I might still ask for conversion) My ranting aside, conversions I've asked for here are trivial and for everyone's benefit /QEMU gets more maintainable code, users less bugs, contributor knows requirements hence his patches go through less iterations, hopefully if contributor stays around and does contributions/reviews to acpi code, QEMU could get another co-maintainer for acpi part/ > I'll move those patches from this serie and build a 6 patches new serie > as suggested. Thanks! > > Cheers, > Samuel. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP Date: Thu, 22 Nov 2018 17:26:52 +0100 Message-ID: <20181122172652.6b02aef6@redhat.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-6-sameo@linux.intel.com> <20181108151623.4de26ecb@redhat.com> <20181121144211.GE4426@caravaggio> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gProk-0004bE-0e for xen-devel@lists.xenproject.org; Thu, 22 Nov 2018 16:27:02 +0000 In-Reply-To: <20181121144211.GE4426@caravaggio> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Samuel Ortiz Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMSBOb3YgMjAxOCAxNTo0MjoxMSArMDEwMApTYW11ZWwgT3J0aXogPHNhbWVvQGxp bnV4LmludGVsLmNvbT4gd3JvdGU6Cgo+IEhpIElnb3IsCj4gCj4gT24gVGh1LCBOb3YgMDgsIDIw MTggYXQgMDM6MTY6MjNQTSArMDEwMCwgSWdvciBNYW1tZWRvdiB3cm90ZToKPiA+IE9uIE1vbiwg IDUgTm92IDIwMTggMDI6NDA6MjggKzAxMDAKPiA+IFNhbXVlbCBPcnRpeiA8c2FtZW9AbGludXgu aW50ZWwuY29tPiB3cm90ZToKPiA+ICAgCj4gPiA+IFhTRFQgaXMgdGhlIDY0LWJpdCB2ZXJzaW9u IG9mIHRoZSBsZWdhY3kgQUNQSSBSU0RUIChSb290IFN5c3RlbQo+ID4gPiBEZXNjcmlwdGlvbiBU YWJsZSkuIFJTRFQgb25seSBhbGxvdyBmb3IgMzItYml0IGFkZHJlc3NzZXMgYW5kIGhhdmUgdGh1 cwo+ID4gPiBiZWVuIGRlcHJlY2F0ZWQuIFNpbmNlIEFDUEkgdmVyc2lvbiAyLjAsIFJTRFBzIHNo b3VsZCBwb2ludCBhdCBYU0RUcyBhbmQKPiA+ID4gbm8gbG9uZ2VyIFJTRFRzLCBhbHRob3VnaCBS U0RUcyBhcmUgc3RpbGwgc3VwcG9ydGVkIGZvciBiYWNrd2FyZAo+ID4gPiBjb21wYXRpYmlsaXR5 Lgo+ID4gPiAKPiA+ID4gU2luY2UgdmVyc2lvbiAyLjAsIFJTRFBzIHNob3VsZCBhZGQgYW4gZXh0 ZW5kZWQgY2hlY2tzdW0sIGEgY29tcGxldGUgdGFibGUKPiA+ID4gbGVuZ3RoIGFuZCBhIHZlcnNp b24gZmllbGQgdG8gdGhlIHRhYmxlLiAgCj4gPiAKPiA+IFRoaXMgcGF0Y2ggcmUtaW1wbGVtZW50 cyB3aGF0IGFybS92aXJ0IGJvYXJkIGFscmVhZHkgZG9lcwo+ID4gYW5kIGZpeGVzIGNoZWNrc3Vt IGJ1ZyBpbiB0aGUgbGF0ZXIgYW5kIGF0IHRoZSBzYW1lIHRpbWUKPiA+IHdpdGhvdXQgYSB1c2Vy ICh3aXRoaW4gdGhlIHBhdGNoKS4KPiA+IAo+ID4gSSdkIHN1Z2dlc3QgcmVkbyBpdCBhIHdheSBz aW1pbGFyIHRvIEZBRFQgcmVmYWN0b3JpbmcKPiA+ICAgcGF0Y2ggMTogZml4IGNoZWNrc3VtIGJ1 ZyBpbiB2aXJ0L2FybQo+ID4gICBwYXRjaCAyOiB1cGRhdGUgcmVmZXJlbmNlIHRhYmxlcyBpbiB0 ZXN0Cj4gPiAgIHBhdGNoIDM6IGludHJvZHVjZSBBY3BpUnNkcERhdGEgc2ltaWxhciB0byBjb21t aXQgOTM3ZDFiNTg3Cj4gPiAgICAgICAgICAgICAgKGJvdGggYXJtIGFuZCB4ODYpIHdpY2ggc3Rv cmVzIGFsbCBkYXRhIGluIGhvcyBieXRlIG9yZGVyCj4gPiAgIHBhdGNoIDQ6IGNvbnZlcnQgYXJt J3MgaW1wbC4gdG8gYnVpbGRfYXBwZW5kX2ludF9ub3ByZWZpeCgpIEFQSSAoY29tbWl0IDVkN2Ez MzRmNykKPiA+Cj4gPiAgICAgICAgICAgIC4uLiBtb3ZlIG91dCB0byBhbWwtYnVpbGQuYwo+ID4g ICBwYXRjaCA1OiByZXVzZSBnZW5lcmFsaXplZCBhcm0ncyBidWlsZF9yc2RwKCkgZm9yIHg4Niwg ZHJvcHBpbmcgeDg2IHNwZWNpZmljIG9uZQo+ID4gICAgICAgYW1lbmRpbmcgaXQgdG8gZ2VuZXJh dGUgcmV2MSB2YXJpYW50IGRlZmluZWQgYnkgcmV2aXNpb24gaW4gQWNwaVJzZHBEYXRhCj4gPiAg ICAgICAoY29tbWl0IGRkMWIyMDM3YSkgIAo+IEkgYWdyZWUgcGF0Y2hlcyAjMSwgIzIgYW5kICM1 IG1ha2Ugc2Vuc2UuIDMgYW5kIDQgYXMgd2VsbCwgYnV0IGhlcmUKPiB5b3UncmUgYXNraW5nIGFi b3V0IHNvbWV0aGluZyB0aGF0J3Mgb3V0IG9mIHNjb3BlIG9mIHRoZSBjdXJyZW50IHNlcmllLgov bWUgZ3VpbHR5IG9mIHRoYXQsIGJ1dCBJIGhhdmUgZXhjdXNlcyBmb3IgZG9pbmcgc286CiAgKiB0 aGF0J3MgdGhlIG9ubHkgd2F5IHRvIGdldCByaWQgb2YgbGVnYWN5IGFwcHJvYWNoIGdpdmVuIGxp bWl0ZWQgcmVzb3VyY2VzLgogICAgU28gdGFzayBnb2VzIHRvIHdob21ldmVyIHRvdWNoZXMgb2xk IGNvZGUuIC9vdGhlcnMgYW5kIG1lIGluY2x1ZGVkLwogICAgSSdkIGJlIGdsYWQgaWYgc29tZW9u ZSB3b3VsZCB2b2x1bnRlZXIgYW5kIGRvIGNsZWFuIHVwcyBidXQgaW4gYWJzZW5jZQogICAgb2Yg c3VjaCwgdGhlIHZpY3RpbSBpcyBpbnRlcmVzdGVkIHBhcnR5LgogICogY29udHJpYnV0b3IgdG8g QUNQSSBwYXJ0IGxlYXJucyBob3cgdG8gdXNlIHByZWZlcnJlZCBhcHByb2FjaCwKICAgIG1ha2Vz IGNvZGUgbW9yZSByb2J1c3QgYW5kIGNsZWFyIGFzIGl0J3Mgbm90IHBvc3NpYmxlIHRvIG1ha2UK ICAgIGVuZGlhbm5lc3MgbWlzdGFrZXMsIHZlcnkgc2ltcGxlIHRvIHJldmlldyBhbmQgbm90aWNl IG1pc3Rha2VzCiAgICBhcyBlbmQgcmVzdWx0IHByYWN0aWNhbGx5IG1hdGNoZXMgcm93IGJ5IHJv dyBhIHRhYmxlIGRlc2NyaWJlZCBpbiBzcGVjLgogICogdGhlcmUgY291bGQgYmUgZXhjZXB0aW9u cywgbGlrZSBhY3BpL252ZGltbS5jIGFsc28gY29udHJpYnV0ZWQgYnkgSW50ZWwKICAgIHdob2xl IGZpbGUgd3JpdHRlbiBpbiBsZWdhY3kgc3R5bGUgKGl0IHByb2JhYmx5IHN0YXJ0ZWQgYmVmb3Jl IEkgc3RhcnRlZAogICAgZW5mb3JjaW5nIGNvbnZlcnNpb25zLCBhbnl3YXlzIGl0J3MgbGF0ZSBu b3cgYW5kIHNob3VsZCBiZSBkb25lIGFzIHdob2xlKSwKICAgIG9yIG9kZCBmaXhlcyB0byBleGlz dGluZyB0YWJsZXMsIG9yIHRvbyBjb21wbGV4IGNhc2UuCiAgICAoZGVwZW5kaW5nIG9uIGNhc2Ug SSBtaWdodCBzdGlsbCBhc2sgZm9yIGNvbnZlcnNpb24pCgpNeSByYW50aW5nIGFzaWRlLCBjb252 ZXJzaW9ucyBJJ3ZlIGFza2VkIGZvciBoZXJlIGFyZSB0cml2aWFsIGFuZCBmb3IKZXZlcnlvbmUn cyBiZW5lZml0IC9RRU1VIGdldHMgbW9yZSBtYWludGFpbmFibGUgY29kZSwgdXNlcnMgbGVzcyBi dWdzLApjb250cmlidXRvciBrbm93cyByZXF1aXJlbWVudHMgaGVuY2UgaGlzIHBhdGNoZXMgZ28g dGhyb3VnaCBsZXNzIGl0ZXJhdGlvbnMsCmhvcGVmdWxseSBpZiBjb250cmlidXRvciBzdGF5cyBh cm91bmQgYW5kIGRvZXMgY29udHJpYnV0aW9ucy9yZXZpZXdzIHRvCmFjcGkgY29kZSwgUUVNVSBj b3VsZCBnZXQgYW5vdGhlciBjby1tYWludGFpbmVyIGZvciBhY3BpIHBhcnQvCgo+IEknbGwgbW92 ZSB0aG9zZSBwYXRjaGVzIGZyb20gdGhpcyBzZXJpZSBhbmQgYnVpbGQgYSA2IHBhdGNoZXMgbmV3 IHNlcmllCj4gYXMgc3VnZ2VzdGVkLgoKVGhhbmtzIQoKPiAKPiBDaGVlcnMsCj4gU2FtdWVsLgo+ IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8v bGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPros-0003Nq-Cb for qemu-devel@nongnu.org; Thu, 22 Nov 2018 11:27:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gProq-0007lW-Jg for qemu-devel@nongnu.org; Thu, 22 Nov 2018 11:27:10 -0500 Date: Thu, 22 Nov 2018 17:26:52 +0100 From: Igor Mammedov Message-ID: <20181122172652.6b02aef6@redhat.com> In-Reply-To: <20181121144211.GE4426@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-6-sameo@linux.intel.com> <20181108151623.4de26ecb@redhat.com> <20181121144211.GE4426@caravaggio> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Ortiz Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Richard Henderson On Wed, 21 Nov 2018 15:42:11 +0100 Samuel Ortiz wrote: > Hi Igor, > > On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:28 +0100 > > Samuel Ortiz wrote: > > > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > > Description Table). RSDT only allow for 32-bit addressses and have thus > > > been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and > > > no longer RSDTs, although RSDTs are still supported for backward > > > compatibility. > > > > > > Since version 2.0, RSDPs should add an extended checksum, a complete table > > > length and a version field to the table. > > > > This patch re-implements what arm/virt board already does > > and fixes checksum bug in the later and at the same time > > without a user (within the patch). > > > > I'd suggest redo it a way similar to FADT refactoring > > patch 1: fix checksum bug in virt/arm > > patch 2: update reference tables in test > > patch 3: introduce AcpiRsdpData similar to commit 937d1b587 > > (both arm and x86) wich stores all data in hos byte order > > patch 4: convert arm's impl. to build_append_int_noprefix() API (commit 5d7a334f7) > > > > ... move out to aml-build.c > > patch 5: reuse generalized arm's build_rsdp() for x86, dropping x86 specific one > > amending it to generate rev1 variant defined by revision in AcpiRsdpData > > (commit dd1b2037a) > I agree patches #1, #2 and #5 make sense. 3 and 4 as well, but here > you're asking about something that's out of scope of the current serie. /me guilty of that, but I have excuses for doing so: * that's the only way to get rid of legacy approach given limited resources. So task goes to whomever touches old code. /others and me included/ I'd be glad if someone would volunteer and do clean ups but in absence of such, the victim is interested party. * contributor to ACPI part learns how to use preferred approach, makes code more robust and clear as it's not possible to make endianness mistakes, very simple to review and notice mistakes as end result practically matches row by row a table described in spec. * there could be exceptions, like acpi/nvdimm.c also contributed by Intel whole file written in legacy style (it probably started before I started enforcing conversions, anyways it's late now and should be done as whole), or odd fixes to existing tables, or too complex case. (depending on case I might still ask for conversion) My ranting aside, conversions I've asked for here are trivial and for everyone's benefit /QEMU gets more maintainable code, users less bugs, contributor knows requirements hence his patches go through less iterations, hopefully if contributor stays around and does contributions/reviews to acpi code, QEMU could get another co-maintainer for acpi part/ > I'll move those patches from this serie and build a 6 patches new serie > as suggested. Thanks! > > Cheers, > Samuel. >