From: Wolfram Sang <wsa@the-dreams.de>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mmc: core: validate user input for RPMB block count
Date: Fri, 23 Nov 2018 00:34:52 +0100 [thread overview]
Message-ID: <20181122233452.GA991@kunai> (raw)
In-Reply-To: <SN6PR04MB49253CEB654E5FE5C69992A1FCDB0@SN6PR04MB4925.namprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
> This might explain why the community people hate JEDEC guys so much.
:D
Okay, this u16 problem of block count exists in mmc-tools, too.
And I'd like to resend this series with a comment added to explain the
situation. Because the specs seem to be easy to get wrong here.
> So this line in mmc_set_blockcount performs an unnecessary input validation.
Even wrong input validation, as I understand it.
> > So you suggest dropping this patch and keep the others, did I get this
> > right? Would be fine with me.
> Yes. Thanks.
Good, let's do this then.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-23 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 23:08 [RFC PATCH 0/3] mmc: refactor RPMB block count handling Wolfram Sang
2018-11-20 23:08 ` [RFC PATCH 1/3] mmc: core: validate user input for RPMB block count Wolfram Sang
2018-11-22 12:15 ` Avri Altman
2018-11-22 14:05 ` Wolfram Sang
2018-11-22 15:57 ` Avri Altman
2018-11-22 23:34 ` Wolfram Sang [this message]
2018-11-25 22:12 ` Clément Péron
2018-11-20 23:08 ` [RFC PATCH 2/3] mmc: core: use mrq->sbc when sending CMD23 for RPMB Wolfram Sang
2018-11-25 22:13 ` Clément Péron
2018-11-20 23:08 ` [RFC PATCH 3/3] mmc: core: remove obsolete mmc_set_blockcount() function Wolfram Sang
2018-11-25 22:13 ` Clément Péron
2018-11-21 0:31 ` [RFC PATCH 0/3] mmc: refactor RPMB block count handling Ulf Hansson
2018-11-21 2:35 ` Wolfram Sang
2018-11-22 10:35 ` Clément Péron
2018-11-24 14:26 ` Clément Péron
2018-11-24 21:37 ` Wolfram Sang
2018-11-25 22:11 ` Clément Péron
2018-11-26 9:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122233452.GA991@kunai \
--to=wsa@the-dreams.de \
--cc=Avri.Altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.