From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Disseldorp Date: Fri, 23 Nov 2018 10:22:08 +0000 Subject: Re: [PATCH] target: drop unnecessary get_fabric_name() accessor from fabric_ops Message-Id: <20181123112208.66708cde@suse.de> List-Id: References: <20181122141623.7507-1-ddiss@suse.de> In-Reply-To: <20181122141623.7507-1-ddiss@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: target-devel@vger.kernel.org On Thu, 22 Nov 2018 23:19:10 -0800, Christoph Hellwig wrote: > On Thu, Nov 22, 2018 at 03:16:23PM +0100, David Disseldorp wrote: > > All fabrics return a const string. In all cases *except* iSCSI the > > get_fabric_name() string matches fabric_ops.name. > > > > Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing, > > with the former being used for PR/ALUA state and the latter for configFS > > (config/target/$name), so we unfortunately need to keep both strings > > around for now. > > Would it make sense to just use .name unless .fabric_name is set > to mostly avoid the duplication? Yeah, was thinking more along the lines of renaming .name to .fabric_alias and only setting it for the "iscsi" configfs case. What's your preference? Cheers, David