From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target: drop unnecessary get_fabric_name() accessor from fabric_ops
Date: Fri, 23 Nov 2018 18:31:28 +0000 [thread overview]
Message-ID: <20181123193128.40c20eba@suse.de> (raw)
In-Reply-To: <20181122141623.7507-1-ddiss@suse.de>
On Fri, 23 Nov 2018 11:22:08 +0100, David Disseldorp wrote:
> > > Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing,
> > > with the former being used for PR/ALUA state and the latter for configFS
> > > (config/target/$name), so we unfortunately need to keep both strings
> > > around for now.
> >
> > Would it make sense to just use .name unless .fabric_name is set
> > to mostly avoid the duplication?
>
> Yeah, was thinking more along the lines of renaming .name to
> .fabric_alias and only setting it for the "iscsi" configfs case.
> What's your preference?
I've sent a follow-up patchset which includes this change as:
[PATCH 3/3] target: replace fabric_ops.name with fabric_alias
Feedback appreciated.
Cheers, David
prev parent reply other threads:[~2018-11-23 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 14:16 [PATCH] target: drop unnecessary get_fabric_name() accessor from fabric_ops David Disseldorp
2018-11-23 7:19 ` Christoph Hellwig
2018-11-23 10:22 ` David Disseldorp
2018-11-23 18:31 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123193128.40c20eba@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.