All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qemu: add an option to enable seccomp
Date: Fri, 23 Nov 2018 22:04:03 +0100	[thread overview]
Message-ID: <20181123220403.059e1442@windsurf> (raw)
In-Reply-To: <20181120131042.6468-1-casantos@datacom.com.br>

Hello,

On Tue, 20 Nov 2018 11:10:42 -0200, Carlos Santos wrote:
> It is required to resume working on the forthcoming libvirt package
> after a long test period (https://patchwork.ozlabs.org/patch/841613).
> 
> Leave it disabled by default, for backward compatibility.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
>  package/qemu/Config.in | 13 +++++++++++++
>  package/qemu/qemu.mk   |  8 +++++++-
>  2 files changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> index 33d4cccd7b..032d2ccafe 100644
> --- a/package/qemu/Config.in
> +++ b/package/qemu/Config.in
> @@ -137,6 +137,19 @@ config BR2_PACKAGE_QEMU_FDT
>  	  Say 'y' here to have QEMU capable of constructing Device
>  	  Trees, and passing them to the VMs.
>  
> +config BR2_PACKAGE_QEMU_SECCOMP
> +	bool "Enable seccomp"
> +	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
> +	select BR2_PACKAGE_LIBSECCOMP
> +	help
> +	  Enable support for the Linux Kernel's syscall filtering
> +	  mechanism.

I don't think we want to introduce an explicit option for this, just
enable seccomp support when BR2_PACKAGE_LIBSSECOMP=y.

> +comment "seccomp needs a toolchain w/ headers >= 3.12"
> +	depends on !BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS || \
> +		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
> +
>  comment "FDT support needs a toolchain w/ dynamic library"
>  	depends on BR2_STATIC_LIBS

This comment should anyway have remained close to the
BR2_PACKAGE_QEMU_FDT option.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-11-23 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 13:10 [Buildroot] [PATCH] qemu: add an option to enable seccomp Carlos Santos
2018-11-20 13:22 ` Carlos Santos
2018-11-23 21:04 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123220403.059e1442@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.