From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1 From: Tony Lindgren Message-Id: <20181125010717.GJ53235@atomide.com> Date: Sat, 24 Nov 2018 17:07:17 -0800 To: Russell King - ARM Linux Cc: Aaro Koskinen , Peter Ujfalusi , vkoul@kernel.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-ID: KiBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggPGxpbnV4QGFybWxpbnV4Lm9yZy51az4gWzE4MTEy NCAyMDoxMF06Cj4gT24gRnJpLCBOb3YgMjMsIDIwMTggYXQgMDg6NTI6MTVQTSArMDIwMCwgQWFy byBLb3NraW5lbiB3cm90ZToKPiA+IEhpLAo+ID4gCj4gPiBPbiBGcmksIE5vdiAyMywgMjAxOCBh dCAwMjozNTowNFBNICswMjAwLCBQZXRlciBVamZhbHVzaSB3cm90ZToKPiA+ID4gT24gMjIvMTEv MjAxOCAxNy4xMiwgUnVzc2VsbCBLaW5nIC0gQVJNIExpbnV4IHdyb3RlOgo+ID4gPiA+IEknbSBh bHNvIG5vdCBzdXJlIGFib3V0IHRoaXM6Cj4gPiA+ID4gCj4gPiA+ID4gICAgICAgICBpZiAoY3B1 X2lzX29tYXAxNXh4KCkpCj4gPiA+ID4gICAgICAgICAgICAgICAgIGVuZCsrOwo+ID4gPiA+IAo+ ID4gPiA+IGluIGRtYV9kZXN0X2xlbigpIC0gaXMgdGhhdCBtaXNzaW5nIGZyb20gdGhlIG9tYXAt ZG1hIGRyaXZlcj8gIEl0IGxvb2tzCj4gPiA+ID4gbGlrZSBhIHdvcmstYXJvdW5kIGZvciBzb21l IHByb2JsZW0gb24gT01BUDE1eHgsIGJ1dCBJIGNhbid0IG1ha2Ugc2Vuc2UKPiA+ID4gPiBhYm91 dCB3aHkgaXQncyBpbiB0aGUgVURDIGRyaXZlciByYXRoZXIgdGhhbiB0aGUgbGVnYWN5IERNQSBk cml2ZXIuCj4gPiA+IAo+ID4gPiBhZmFpayBubyBvdGhlciBsZWdhY3kgZHJpdmVycyB3ZXJlIGRv aW5nIHNpbWlsYXIgdGhpbmcsIHRoaXMgbXVzdCBiZQo+ID4gPiBzb21ldGhpbmcgd2hpY2ggaXMg bmVlZGVkIGZvciB0aGUgb21hcF91ZGMgZHJpdmVyIHRvIGZpeCB1cCBzb21ldGhpbmc/Cj4gPiAK PiA+IEhlcmUncyB0aGUgcGF0Y2ggdGhhdCBhZGRlZCBpdDogaHR0cHM6Ly9tYXJjLmluZm8vP2w9 bGludXgtb21hcCZtPTExOTYzNDM5NjMyNDIyMSZ3PTIKPiA+IAo+ID4gIk1ha2UgRE1BLU9VVCBi ZWhhdmUgb24gdGhlIDE1MTAgLi4uIHRoZSAxNTEwIENQQyByZWdpc3RlciB3YXMganVzdAo+ID4g b2ZmLWJ5LW9uZSB3aXRoIHJlc3BlY3QgdG8gdGhlIDE2MTEgQ0RBQyIKPiAKPiAuLi4gd2hpY2gg c3VnZ2VzdHMgdGhhdCdzIGEgcHJvYmxlbSB3aXRoIHRoZSBDUEMgcmVnaXN0ZXIgaXRzZWxmLCBh bmQKPiB3ZSBzaG91bGQgZml4IHRoYXQgaW4gdGhlIERNQWVuZ2luZSBkcml2ZXIgcmF0aGVyIHRo YW4gdGhlIFVTQiBnYWRnZXQKPiBkcml2ZXIuCj4gCj4gVG9ueSwgYW55IGlucHV0IG9uIHRoaXM/ CgpZZWFoIHRoYXQgc291bmRzIGxpa2Ugc29tZSBoYXJkd2FyZSB3b3JrLWFyb3VuZCBmb3IgMTV4 eCBhcyBkZXNjcmliZWQKaW4gdGhlIERNQV9ERVNUX0xBU1QgbWFjcm8gcmVhZGluZyBDU0FDIG9u IDE1eHggaW5zdGVhZCBvZiBDREFDLiBTZWVtcwpsaWtlIGl0IHNob3VsZCBiZSBkb25lIGluIHRo ZSBkbWFlbmdpbmUgZHJpdmVyLi4gTXkgZ3Vlc3MgaXMgdGhhdCBvdGhlcgpkbWEgdXNlcnMgbmV2 ZXIgbmVlZGVkIHRvIHJlYWQgQ1NBQyByZWdpc3Rlcj8KClJlZ2FyZHMsCgpUb255Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1 Date: Sat, 24 Nov 2018 17:07:17 -0800 Message-ID: <20181125010717.GJ53235@atomide.com> References: <20181119104040.12885-1-peter.ujfalusi@ti.com> <20181119184649.GE16897@darkstar.musicnaut.iki.fi> <6af8c6e7-bf5c-5555-161b-5d3fb7ecae43@ti.com> <20181120210406.GB24888@darkstar.musicnaut.iki.fi> <20181122102948.GN6920@n2100.armlinux.org.uk> <20181122151236.GA9611@n2100.armlinux.org.uk> <6ed280af-edb6-4be7-82f4-7fc00378103e@ti.com> <20181123185215.GH12912@darkstar.musicnaut.iki.fi> <20181124200942.GS6920@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181124200942.GS6920@n2100.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Aaro Koskinen , Peter Ujfalusi , vkoul@kernel.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Russell King - ARM Linux [181124 20:10]: > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > Hi, > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > > > I'm also not sure about this: > > > > > > > > if (cpu_is_omap15xx()) > > > > end++; > > > > > > > > in dma_dest_len() - is that missing from the omap-dma driver? It looks > > > > like a work-around for some problem on OMAP15xx, but I can't make sense > > > > about why it's in the UDC driver rather than the legacy DMA driver. > > > > > > afaik no other legacy drivers were doing similar thing, this must be > > > something which is needed for the omap_udc driver to fix up something? > > > > Here's the patch that added it: https://marc.info/?l=linux-omap&m=119634396324221&w=2 > > > > "Make DMA-OUT behave on the 1510 ... the 1510 CPC register was just > > off-by-one with respect to the 1611 CDAC" > > ... which suggests that's a problem with the CPC register itself, and > we should fix that in the DMAengine driver rather than the USB gadget > driver. > > Tony, any input on this? Yeah that sounds like some hardware work-around for 15xx as described in the DMA_DEST_LAST macro reading CSAC on 15xx instead of CDAC. Seems like it should be done in the dmaengine driver.. My guess is that other dma users never needed to read CSAC register? Regards, Tony