All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] iio: accel: kxcjk-1013: Add the "KXJ2109" ACPI HID
Date: Sun, 25 Nov 2018 09:09:30 +0000	[thread overview]
Message-ID: <20181125090930.0086a021@archlinux> (raw)
In-Reply-To: <20181124162220.8523-1-stephan@gerhold.net>

On Sat, 24 Nov 2018 17:22:20 +0100
Stephan Gerhold <stephan@gerhold.net> wrote:

> This HID is used on the ASUS MeMO Pad 7 (ME176C) tablet.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Other than a distinct temptation to rant about formats
of ACPI IDs (4 characters the a number), looks good.

For reference (I was waiting for a build so decided to dig
it out ;)
ACPI 6.2 spec. 6.5.1

"A valid ACPI ID must be of the form "NNNN####" where N is an uppercase letter or a
digit ('0'-'9') and # is a hex digit." is the text about a manufacturer defined
ID.

If anyone has a contact at ASUS who I can rant at do pass it on!

Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/kxcjk-1013.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index af53a1084ee5..cc5b2beb1328 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1491,6 +1491,7 @@ static const struct acpi_device_id kx_acpi_match[] = {
>  	{"KXCJ9000", KXCJ91008},
>  	{"KIOX000A", KXCJ91008},
>  	{"KXTJ1009", KXTJ21009},
> +	{"KXJ2109",  KXTJ21009},
>  	{"SMO8500",  KXCJ91008},
>  	{ },
>  };

  reply	other threads:[~2018-11-25 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 16:22 [PATCH] iio: accel: kxcjk-1013: Add the "KXJ2109" ACPI HID Stephan Gerhold
2018-11-25  9:09 ` Jonathan Cameron [this message]
2018-11-25 11:03   ` Himanshu Jha
2018-11-25 14:14   ` Stephan Gerhold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181125090930.0086a021@archlinux \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.