All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Smith <andy@strugglers.net>
To: xen-devel@lists.xenproject.org
Subject: Re: Sporadic PV guest malloc.c assertion failures and segfaults unless pv-l1tf=false is set
Date: Sun, 25 Nov 2018 09:14:13 +0000	[thread overview]
Message-ID: <20181125091413.GY3695@bitfolk.com> (raw)
In-Reply-To: <20181125061849.GI4569@bitfolk.com>

Hello,

On Sun, Nov 25, 2018 at 06:18:49AM +0000, Andy Smith wrote:
> In the text for XSA-273 it says:
> 
>     "Shadowing comes with a workload-dependent performance hit to
>     the guest.  Once the guest kernel software updates have been
>     applied, a well behaved guest will not write vulnerable PTEs,
>     and will therefore avoid the performance penalty (or crash)
>     entirely."
> 
> Does anyone have a reference to what is needed in the Linux kernel
> for that?

Perhaps stupidly, I have only just now thought to check whether the
one guest I have an easy reproducer on (predictable failure of
php-fpm) was actually running an up to date kernel. It was not.

It is Debian stretch and was running kernel package
linux-image-4.9.0-7-amd64 version 4.9.110-3+deb9u2. The guest's
administrator obviously had not done any upgrades since install time
because updated kernel linux-image-4.9.0-8-amd64 version 4.9.130-2
was available.

After installing and booting with that, the guest no longer causes
"L1TF-vulnerable L1e 000000006a6ff960 - Shadowing" to be emitted in
the hypervisor dmesg, and the problems I described disappear.

I assume this is because of:

https://metadata.ftp-master.debian.org/changelogs//main/l/linux/linux_4.9.130-2_changelog

    linux (4.9.110-3+deb9u3) stretch-security; urgency=high

      [ Salvatore Bonaccorso ]
        * Add L1 Terminal Fault fixes (CVE-2018-3620, CVE-2018-3646)

So, I can tell affected guest administrators to upgrade their
kernels to include Linux's L1TF protections and their problems
should go away.

Do you care that without those fixes there appear to be memory
corruption issues? If so, I can keep this reproducer guest around
and debug it further.

Cheers,
Andy

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-11-25  9:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25  6:18 Sporadic PV guest malloc.c assertion failures and segfaults unless pv-l1tf=false is set Andy Smith
2018-11-25  9:14 ` Andy Smith [this message]
2018-11-25 14:48   ` Andrew Cooper
2018-11-25 16:29     ` Andy Smith
2018-11-25 17:14       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181125091413.GY3695@bitfolk.com \
    --to=andy@strugglers.net \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.