diff for duplicates of <20181125132257.6ae9fe82@archlinux> diff --git a/a/1.txt b/N1/1.txt index 8b78954..974ab5a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,28 +1,24 @@ On Wed, 21 Nov 2018 13:13:40 +0800 Jian-Hong Pan <jian-hong@endlessm.com> wrote: -> Denis CIOCCA <denis.ciocca@st.com> =E6=96=BC 2018=E5=B9=B411=E6=9C=8820= -=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8A=E5=8D=883:05=E5=AF=AB=E9=81=93=EF=BC= -=9A +> Denis CIOCCA <denis.ciocca@st.com> 於 2018年11月20日 週二 上午3:05寫道： > > > > Hi Jian, > > > > Not clear to me why should be + instead of *. > > -> > ODR is expressed in Hz, so (1/Hz) =3D period in seconds (1 sample sampl= -ing time) [s] -> > 1000 * (1/Hz) =3D period in milliseconds (1 sample sampling time) [ms] -> > n * 1000 * (1/Hz) =3D n times period in milliseconds (n times sample sa= -mpling time) [ms] +> > ODR is expressed in Hz, so (1/Hz) = period in seconds (1 sample sampling time) [s] +> > 1000 * (1/Hz) = period in milliseconds (1 sample sampling time) [ms] +> > n * 1000 * (1/Hz) = n times period in milliseconds (n times sample sampling time) [ms] > > -> > In your case you assume bootime is in milliseconds. =20 ->=20 +> > In your case you assume bootime is in milliseconds. +> > Yes, I assume that according to the original comment. ->=20 -> >Maybe we can change the comment and use 'number of samples ...'. =20 ->=20 +> +> >Maybe we can change the comment and use 'number of samples ...'. +> > Making the meaning more clear is better. ->=20 +> > However, does the bootime of the measurement need as the long time to > be enabled? > If the sampling rate is 1Hz and n is 2, then they will do msleep with @@ -37,27 +33,21 @@ I'm not understanding why this is unexpected? Jonathan ->=20 +> > Regards, > Jian-Hong Pan ->=20 +> > > > > > > -----Original Message----- -> > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org>= - On Behalf Of Jian-Hong Pan +> > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> On Behalf Of Jian-Hong Pan > > Sent: Sunday, November 18, 2018 10:12 PM -> > To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.d= -e>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pm= -eerw.net>; Dominique Martinet <asmadeus@codewreck.org> -> > Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux@endl= -essm.com; Jian-Hong Pan <jian-hong@endlessm.com> +> > To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>; Dominique Martinet <asmadeus@codewreck.org> +> > Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan <jian-hong@endlessm.com> > > Subject: [PATCH] iio: st_sensors: Fix the sleep time for sampling > > -> > According to the description of st_sensor_settings and st_sensor_data s= -tructures' comments: -> > - bootime: samples to discard when sensor passing from power-down to po= -wer-up. +> > According to the description of st_sensor_settings and st_sensor_data structures' comments: +> > - bootime: samples to discard when sensor passing from power-down to power-up. > > - odr: Output data rate of the sensor [Hz]. > > > > The sleep time should be @@ -68,23 +58,19 @@ wer-up. > > drivers/iio/common/st_sensors/st_sensors_core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > -> > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/= -iio/common/st_sensors/st_sensors_core.c +> > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c > > index 26fbd1bd9413..6b87ea657a92 100644 > > --- a/drivers/iio/common/st_sensors/st_sensors_core.c > > +++ b/drivers/iio/common/st_sensors/st_sensors_core.c -> > @@ -594,7 +594,7 @@ int st_sensors_read_info_raw(struct iio_dev *indio_= -dev, +> > @@ -594,7 +594,7 @@ int st_sensors_read_info_raw(struct iio_dev *indio_dev, > > if (err < 0) > > goto out; > > -> > - msleep((sdata->sensor_settings->bootime * 1000) / sdata= -->odr); -> > + msleep(sdata->sensor_settings->bootime + 1000 / sdata->= -odr); -> > err =3D st_sensors_read_axis_data(indio_dev, ch, val); +> > - msleep((sdata->sensor_settings->bootime * 1000) / sdata->odr); +> > + msleep(sdata->sensor_settings->bootime + 1000 / sdata->odr); +> > err = st_sensors_read_axis_data(indio_dev, ch, val); > > if (err < 0) > > goto out; > > -- > > 2.11.0 -> > =20 +> > diff --git a/a/content_digest b/N1/content_digest index e89840f..eba7d50 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,28 +18,24 @@ "On Wed, 21 Nov 2018 13:13:40 +0800\n" "Jian-Hong Pan <jian-hong@endlessm.com> wrote:\n" "\n" - "> Denis CIOCCA <denis.ciocca@st.com> =E6=96=BC 2018=E5=B9=B411=E6=9C=8820=\n" - "=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8A=E5=8D=883:05=E5=AF=AB=E9=81=93=EF=BC=\n" - "=9A\n" + "> Denis CIOCCA <denis.ciocca@st.com> \346\226\274 2018\345\271\26411\346\234\21020\346\227\245 \351\200\261\344\272\214 \344\270\212\345\215\2103:05\345\257\253\351\201\223\357\274\232\n" "> >\n" "> > Hi Jian,\n" "> >\n" "> > Not clear to me why should be + instead of *.\n" "> >\n" - "> > ODR is expressed in Hz, so (1/Hz) =3D period in seconds (1 sample sampl=\n" - "ing time) [s]\n" - "> > 1000 * (1/Hz) =3D period in milliseconds (1 sample sampling time) [ms]\n" - "> > n * 1000 * (1/Hz) =3D n times period in milliseconds (n times sample sa=\n" - "mpling time) [ms]\n" + "> > ODR is expressed in Hz, so (1/Hz) = period in seconds (1 sample sampling time) [s]\n" + "> > 1000 * (1/Hz) = period in milliseconds (1 sample sampling time) [ms]\n" + "> > n * 1000 * (1/Hz) = n times period in milliseconds (n times sample sampling time) [ms]\n" "> >\n" - "> > In your case you assume bootime is in milliseconds. =20\n" - ">=20\n" + "> > In your case you assume bootime is in milliseconds. \n" + "> \n" "> Yes, I assume that according to the original comment.\n" - ">=20\n" - "> >Maybe we can change the comment and use 'number of samples ...'. =20\n" - ">=20\n" + "> \n" + "> >Maybe we can change the comment and use 'number of samples ...'. \n" + "> \n" "> Making the meaning more clear is better.\n" - ">=20\n" + "> \n" "> However, does the bootime of the measurement need as the long time to\n" "> be enabled?\n" "> If the sampling rate is 1Hz and n is 2, then they will do msleep with\n" @@ -54,27 +50,21 @@ "\n" "Jonathan\n" "\n" - ">=20\n" + "> \n" "> Regards,\n" "> Jian-Hong Pan\n" - ">=20\n" + "> \n" "> >\n" "> >\n" "> > -----Original Message-----\n" - "> > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org>=\n" - " On Behalf Of Jian-Hong Pan\n" + "> > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> On Behalf Of Jian-Hong Pan\n" "> > Sent: Sunday, November 18, 2018 10:12 PM\n" - "> > To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.d=\n" - "e>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pm=\n" - "eerw.net>; Dominique Martinet <asmadeus@codewreck.org>\n" - "> > Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux@endl=\n" - "essm.com; Jian-Hong Pan <jian-hong@endlessm.com>\n" + "> > To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>; Dominique Martinet <asmadeus@codewreck.org>\n" + "> > Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan <jian-hong@endlessm.com>\n" "> > Subject: [PATCH] iio: st_sensors: Fix the sleep time for sampling\n" "> >\n" - "> > According to the description of st_sensor_settings and st_sensor_data s=\n" - "tructures' comments:\n" - "> > - bootime: samples to discard when sensor passing from power-down to po=\n" - "wer-up.\n" + "> > According to the description of st_sensor_settings and st_sensor_data structures' comments:\n" + "> > - bootime: samples to discard when sensor passing from power-down to power-up.\n" "> > - odr: Output data rate of the sensor [Hz].\n" "> >\n" "> > The sleep time should be\n" @@ -85,25 +75,21 @@ "> > drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-\n" "> > 1 file changed, 1 insertion(+), 1 deletion(-)\n" "> >\n" - "> > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/=\n" - "iio/common/st_sensors/st_sensors_core.c\n" + "> > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c\n" "> > index 26fbd1bd9413..6b87ea657a92 100644\n" "> > --- a/drivers/iio/common/st_sensors/st_sensors_core.c\n" "> > +++ b/drivers/iio/common/st_sensors/st_sensors_core.c\n" - "> > @@ -594,7 +594,7 @@ int st_sensors_read_info_raw(struct iio_dev *indio_=\n" - "dev,\n" + "> > @@ -594,7 +594,7 @@ int st_sensors_read_info_raw(struct iio_dev *indio_dev,\n" "> > if (err < 0)\n" "> > goto out;\n" "> >\n" - "> > - msleep((sdata->sensor_settings->bootime * 1000) / sdata=\n" - "->odr);\n" - "> > + msleep(sdata->sensor_settings->bootime + 1000 / sdata->=\n" - "odr);\n" - "> > err =3D st_sensors_read_axis_data(indio_dev, ch, val);\n" + "> > - msleep((sdata->sensor_settings->bootime * 1000) / sdata->odr);\n" + "> > + msleep(sdata->sensor_settings->bootime + 1000 / sdata->odr);\n" + "> > err = st_sensors_read_axis_data(indio_dev, ch, val);\n" "> > if (err < 0)\n" "> > goto out;\n" "> > --\n" "> > 2.11.0\n" - > > =20 + > > -1dfc9abfa4596babefa02d11a4b9745deb248f003c87183a2eb0e3b05bfc8616 +7e0dbb5c310aaf29fc7a4853b6cb5fdf47dbf42a785941c6259202eaa74b41f8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.