From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Carmeli Tamir <carmeli.tamir@gmail.com>
Cc: axboe@kernel.dk, sergey.senozhatsky@gmail.com,
jthumshirn@suse.de, bvanassche@acm.org,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Replaced 11 magic to MSDOS_NAME for volume label
Date: Mon, 26 Nov 2018 14:07:08 +0900 [thread overview]
Message-ID: <20181126050708.GE540@jagdpanzerIV> (raw)
In-Reply-To: <1543096879-82837-1-git-send-email-carmeli.tamir@gmail.com>
On (11/24/18 17:01), Carmeli Tamir wrote:
> The FAT file system volume label file stored in the root directory should
> match the volume label field in the FAT boot sector. As consequence, the
> max length of these fields ought to be the same. This patch replaces the
> magic '11' usef in the struct fat_boot_sector with MSDOS_NAME,
> which is used in struct msdos_dir_entry.
>
> Please check the following references:
> 1. Microsoft FAT specification 2005
> (http://read.pudn.com/downloads77/ebook/294884/FAT32%20Spec%20%28SDA%20Contribution%29.pdf).
[..]
> Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Looks good to me,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
next prev parent reply other threads:[~2018-11-26 5:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 22:01 [PATCH] fat: Replaced 11 magic to MSDOS_NAME for volume label Carmeli Tamir
2018-11-26 5:07 ` Sergey Senozhatsky [this message]
2018-11-26 7:58 ` Johannes Thumshirn
2018-11-26 19:23 ` Tamir Carmeli
2018-11-27 1:40 ` Sergey Senozhatsky
2018-11-27 2:08 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126050708.GE540@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=carmeli.tamir@gmail.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.