From: Greg KH <greg@kroah.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Dave Stevenson <dave.stevenson@raspberrypi.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
mchehab@kernel.org, linux-media@vger.kernel.org,
"for 4.14 and up" <stable@vger.kernel.org>
Subject: Re: [PATCH v3.16 2/2] v4l: event: Add subscription to list before calling "add" operation
Date: Mon, 26 Nov 2018 08:34:22 +0100 [thread overview]
Message-ID: <20181126073422.GF18375@kroah.com> (raw)
In-Reply-To: <20181108120350.17266-3-sakari.ailus@linux.intel.com>
On Thu, Nov 08, 2018 at 02:03:50PM +0200, Sakari Ailus wrote:
> [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ]
>
> Patch ad608fbcf166 changed how events were subscribed to address an issue
> elsewhere. As a side effect of that change, the "add" callback was called
> before the event subscription was added to the list of subscribed events,
> causing the first event queued by the add callback (and possibly other
> events arriving soon afterwards) to be lost.
>
> Fix this by adding the subscription to the list before calling the "add"
> callback, and clean up afterwards if that fails.
>
> Fixes: ad608fbcf166 ("media: v4l: event: Prevent freeing event subscriptions while accessed")
Now applied, thanks.
greg k-h
next prev parent reply other threads:[~2018-11-26 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 12:03 [PATCH v3.16 0/2] V4L2 event subscription fixes Sakari Ailus
2018-11-08 12:03 ` [PATCH v3.16 1/2] v4l: event: Prevent freeing event subscriptions while accessed Sakari Ailus
2018-11-26 7:33 ` Greg KH
2018-11-08 12:03 ` [PATCH v3.16 2/2] v4l: event: Add subscription to list before calling "add" operation Sakari Ailus
2018-11-26 7:34 ` Greg KH [this message]
2019-01-02 19:01 ` Ben Hutchings
2019-01-03 0:58 ` Yi Qingliang
2019-01-03 10:15 ` Hans Verkuil
2019-01-03 12:00 ` Yi Qingliang
2018-11-09 23:12 ` [PATCH v3.16 0/2] V4L2 event subscription fixes Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126073422.GF18375@kroah.com \
--to=greg@kroah.com \
--cc=ben@decadent.org.uk \
--cc=dave.stevenson@raspberrypi.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.