From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: linux-next: build warning after merge of the btrfs-kdave tree Date: Mon, 26 Nov 2018 08:56:11 +0100 Message-ID: <20181126075611.GA799@lst.de> References: <20181126110629.45969c51@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181126110629.45969c51@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Rothwell Cc: David Sterba , Kees Cook , Linux Next Mailing List , Linux Kernel Mailing List , Christoph Hellwig List-Id: linux-next.vger.kernel.org On Mon, Nov 26, 2018 at 11:06:29AM +1100, Stephen Rothwell wrote: > Introduced by commit > > cf8cddd38bab3 ("btrfs: don't abuse REQ_OP_* flags for btrfs_map_block") > > exposed by my new use of -Wimplicit-fallthrough > > I am not sure why this has only turned up now (as opposed to earlier > today). It looks like something only in linux-next moved the code around a bit. Either way the fallthough looks fine, it will just need a little /*FALLTHRU*/ annotation.