From: Oleg Nesterov <oleg@redhat.com>
To: Elvira Khabirova <lineprinter@altlinux.org>
Cc: rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, ldv@altlinux.org, esyr@redhat.com,
luto@kernel.org, strace-devel@lists.strace.io,
linux-api@vger.kernel.org
Subject: Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message
Date: Mon, 26 Nov 2018 15:56:43 +0100 [thread overview]
Message-ID: <20181126145643.GD1660@redhat.com> (raw)
In-Reply-To: <20181125022227.55e8caf7@akathisia>
On 11/25, Elvira Khabirova wrote:
>
> + * These values are stored in task->ptrace_message by tracehook_report_syscall_*
> + * to describe current syscall-stop.
> + *
> + * Values for these constants are chosen so that they do not appear
> + * in task->ptrace_message by other means.
> + */
> +#define PTRACE_EVENTMSG_SYSCALL_ENTRY 0x80000000U
> +#define PTRACE_EVENTMSG_SYSCALL_EXIT 0x90000000U
Stupid question, why not
#define PTRACE_EVENT_SYSCALL_ENTRY 8
#define PTRACE_EVENT_SYSCALL_EXIT 9
right after other PTRACE_EVENT_* constants?
The next 3/3 tries to detect PTRACE_EVENT_SECCOMP case anyway, so I am not sure
I understand what "do not appear in task->ptrace_message by other means" actually
means...
Oleg.
next prev parent reply other threads:[~2018-11-26 14:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 1:21 [PATCH RESEND v3 0/3] ptrace: add PTRACE_GET_SYSCALL_INFO request Elvira Khabirova
2018-11-25 1:21 ` Elvira Khabirova
2018-11-25 1:22 ` [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message Elvira Khabirova
2018-11-25 1:22 ` Elvira Khabirova
2018-11-25 1:54 ` Joey Pabalinas
[not found] ` <20181125015402.glcaw3kghcu4pr22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-11-25 2:10 ` Dmitry V. Levin
2018-11-25 2:10 ` Dmitry V. Levin
[not found] ` <20181125021059.GA1190-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org>
2018-11-25 6:17 ` Joey Pabalinas
2018-11-25 6:17 ` Joey Pabalinas
2018-11-26 14:56 ` Oleg Nesterov [this message]
[not found] ` <20181126145643.GD1660-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-27 2:53 ` Elvira Khabirova
2018-11-27 2:53 ` Elvira Khabirova
2018-11-27 3:48 ` Dmitry V. Levin
2018-11-25 1:23 ` [PATCH RESEND v3 2/3] ptrace: add PTRACE_GET_SYSCALL_INFO request Elvira Khabirova
2018-11-25 1:23 ` Elvira Khabirova
2018-11-25 1:23 ` [RFC PATCH RESEND v3 3/3] ptrace: add PTRACE_EVENT_SECCOMP support to PTRACE_GET_SYSCALL_INFO Elvira Khabirova
2018-11-25 1:23 ` Elvira Khabirova
2018-11-26 14:35 ` Oleg Nesterov
2018-11-26 14:35 ` Oleg Nesterov
[not found] ` <20181126143524.GB1660-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-27 3:07 ` Elvira Khabirova
2018-11-27 3:07 ` Elvira Khabirova
2018-11-27 3:21 ` Dmitry V. Levin
2018-11-27 3:21 ` Dmitry V. Levin
2018-11-27 12:31 ` Oleg Nesterov
[not found] ` <20181127123116.GA13284-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-27 23:27 ` Dmitry V. Levin
2018-11-27 23:27 ` Dmitry V. Levin
2018-11-28 12:35 ` Oleg Nesterov
[not found] ` <20181128123545.GA30395-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-28 12:44 ` Dmitry V. Levin
2018-11-28 12:44 ` Dmitry V. Levin
2018-11-28 13:13 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126145643.GD1660@redhat.com \
--to=oleg@redhat.com \
--cc=esyr@redhat.com \
--cc=ldv@altlinux.org \
--cc=lineprinter@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=strace-devel@lists.strace.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.