From: "Woods, Brian" <Brian.Woods@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
Xen-devel <xen-devel@lists.xen.org>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Woods, Brian" <Brian.Woods@amd.com>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 3/4] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests
Date: Mon, 26 Nov 2018 15:28:07 +0000 [thread overview]
Message-ID: <20181126152803.GA28856@amd.com> (raw)
In-Reply-To: <1542318438-20319-4-git-send-email-andrew.cooper3@citrix.com>
On Thu, Nov 15, 2018 at 09:47:17PM +0000, Andy Cooper wrote:
> With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common
> code. Move its storage into struct vcpu_msrs (dropping the HVM-specific
> msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the
> presence of the MSR.
>
> Drop hvm_msr_tsc_aux() entirely, and use v->arch.msrs->tsc_aux directly.
> Update hvm_load_cpu_ctxt() to check that the incoming ctxt.msr_tsc_aux isn't
> out of range. In practice, no previous version of Xen ever wrote an
> out-of-range value. Add MSR_TSC_AUX to the list of MSRs migrated for PV
> guests.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Brian Woods <brian.woods@amd.com>
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-26 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 21:47 [PATCH 0/4] x86: Drop PVRDTSCP and fix MSR_TSC_AUX handling for guests Andrew Cooper
2018-11-15 21:47 ` [PATCH 1/4] x86: Begin to remove TSC mode PVRDTSCP Andrew Cooper
2018-11-19 15:25 ` Jan Beulich
2018-11-20 11:14 ` Andrew Cooper
2018-11-15 21:47 ` [PATCH 2/4] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op() Andrew Cooper
2018-11-20 8:40 ` Jan Beulich
2018-11-15 21:47 ` [PATCH 3/4] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests Andrew Cooper
2018-11-20 10:58 ` Jan Beulich
2018-11-26 15:28 ` Woods, Brian [this message]
2018-11-15 21:47 ` [PATCH 4/4] x86/pv: Expose RDTSCP to PV guests Andrew Cooper
2018-11-20 11:06 ` Jan Beulich
2018-11-20 11:29 ` Andrew Cooper
2018-11-20 15:14 ` Jan Beulich
2018-11-16 10:11 ` [PATCH 0/4] x86: Drop PVRDTSCP and fix MSR_TSC_AUX handling for guests Jan Beulich
2018-11-16 17:43 ` Andrew Cooper
2018-11-16 19:55 ` Konrad Rzeszutek Wilk
2018-11-19 8:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126152803.GA28856@amd.com \
--to=brian.woods@amd.com \
--cc=JBeulich@suse.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.