From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp5745607wrt; Mon, 26 Nov 2018 07:48:24 -0800 (PST) X-Google-Smtp-Source: AFSGD/U8DqEfnnFShgYBWJvkc9BSdyXL8PnnwJAnWSWRch3X7L2DIawAY9ikhiE/lNGtCjxYWxdg X-Received: by 2002:a25:ad4a:: with SMTP id l10-v6mr28601523ybe.10.1543247304134; Mon, 26 Nov 2018 07:48:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543247304; cv=none; d=google.com; s=arc-20160816; b=VC0ko/F8pQHz25BkUO7Ebz6agpUy4TSXWWQqcR0xsGEtxofGON5LM2qlT18pIHwnk1 lJzbLIu2aKegA8h/DlA157QFsEKfmAi35Iyum2HBU5G+7wnXkux6M6v66lLT4UEPsCSw SnDyJ40od8TzyxGYTykj/v3TlJh/Gw8rANM33uw9/gZ60Js/KALep16VjfPcKss2TmHb 3YpmVocJB3kZ/RToW8fhbKJzgTYinFfL8bTEvXDiCC80Eibbl+X+/X4CTYGroby3t+Rr mMfaiBPsxcWScpqxjw8mCoRnb7Qq27xvRaCbZA6jS8m1FVN+p2pir1+ObYwWY5wgZBQa O8jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:to:from:date; bh=a22Efh3VWmrIv/mL2Fn7McCrW7sEvSi8YqsaRoZiYcI=; b=NdIxLARDdx9QciD1aroSqSEUh2jXcw8m0ESpUSvSogg58zSHEv+plqBLBVNS+IKxR3 o1mjsv48kIjM7iPsU8SdHD4kk853rEDEGtal8bjpilll/+VODOuhb1DvTnkWodMO4mlr fiMi2BTVDSLegCuCTNFAutDb+psNyNuZCrGGcM83X3zsEiu4iCIEokbmXCgrnO5L5ZcP c+Y0mrekrIXGnrOh5nkw73RQ1qORxWij0KP1d1s2d0+P/J7FFGD359RHzPfDrJpMzrwc EfeWPRO1Q8PLpRs2YlJNmUKoVymRgcLCp8ViQssjiOHDh5SHyABeVdcdrkmyysRTXUdY PD0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y1si496280ywf.391.2018.11.26.07.48.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 26 Nov 2018 07:48:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:37336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRJ7X-00062v-KC for alex.bennee@linaro.org; Mon, 26 Nov 2018 10:48:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRJ7N-00061L-0a for qemu-arm@nongnu.org; Mon, 26 Nov 2018 10:48:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRJ7H-00026U-4v for qemu-arm@nongnu.org; Mon, 26 Nov 2018 10:48:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43373) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRJ7E-0001si-AJ; Mon, 26 Nov 2018 10:48:04 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B2B1C01F621; Mon, 26 Nov 2018 15:48:02 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8C026269C; Mon, 26 Nov 2018 15:47:53 +0000 (UTC) Date: Mon, 26 Nov 2018 16:47:51 +0100 From: Igor Mammedov To: Samuel Ortiz Message-ID: <20181126164751.4e304b46@redhat.com> In-Reply-To: <20181121232733.GC4450@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-16-sameo@linux.intel.com> <20181115142854.1c62f32f@redhat.com> <20181121232733.GC4450@caravaggio> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 26 Nov 2018 15:48:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: CtPmXPAg9D4X On Thu, 22 Nov 2018 00:27:33 +0100 Samuel Ortiz wrote: > On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:38 +0100 > > Samuel Ortiz wrote: > > > > > This is the standard way of building SRAT on x86 platfoms. But future > > > machine types could decide to define their own custom SRAT build method > > > through the ACPI builder methods. > > > Moreover, we will also need to reach build_srat() from outside of > > > acpi-build in order to use it as the ACPI builder SRAT build method. > > SRAT is usually highly machine specific (memory holes, layout, guest OS > > specific quirks) so it's hard to generalize it. > Hence the need for an SRAT builder interface. so far builder interface (trying to generalize acpi_build()) looks not necessary. I'd suggest to drop and call build_start() directly. > > I'd drop SRAT related patches from this series and introduce > > i386/virt specific SRAT when you post patches for it. > virt uses the existing i386 build_srat() routine, there's nothing > special about it. So this would be purely duplicated code. Looking at build_srat(), it has a bunch of code to handle legacy PC layout. You probably don't need any of it for new is86/virt machine and can make simpler version of it. In addition (probably repeating question I've asked elsewhere), Do you have to use split initial memory model for new machine? Is it possible to use only pc-dimms both for initial and hotplugged memory at some address (4Gb?) without cutting out PCI hole or any toher holes in RAM layout? > Cheers, > Samuel. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method Date: Mon, 26 Nov 2018 16:47:51 +0100 Message-ID: <20181126164751.4e304b46@redhat.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-16-sameo@linux.intel.com> <20181115142854.1c62f32f@redhat.com> <20181121232733.GC4450@caravaggio> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gRJ7E-0006FV-7x for xen-devel@lists.xenproject.org; Mon, 26 Nov 2018 15:48:04 +0000 In-Reply-To: <20181121232733.GC4450@caravaggio> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Samuel Ortiz Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAyMiBOb3YgMjAxOCAwMDoyNzozMyArMDEwMApTYW11ZWwgT3J0aXogPHNhbWVvQGxp bnV4LmludGVsLmNvbT4gd3JvdGU6Cgo+IE9uIFRodSwgTm92IDE1LCAyMDE4IGF0IDAyOjI4OjU0 UE0gKzAxMDAsIElnb3IgTWFtbWVkb3Ygd3JvdGU6Cj4gPiBPbiBNb24sICA1IE5vdiAyMDE4IDAy OjQwOjM4ICswMTAwCj4gPiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4gd3Jv dGU6Cj4gPiAgIAo+ID4gPiBUaGlzIGlzIHRoZSBzdGFuZGFyZCB3YXkgb2YgYnVpbGRpbmcgU1JB VCBvbiB4ODYgcGxhdGZvbXMuIEJ1dCBmdXR1cmUKPiA+ID4gbWFjaGluZSB0eXBlcyBjb3VsZCBk ZWNpZGUgdG8gZGVmaW5lIHRoZWlyIG93biBjdXN0b20gU1JBVCBidWlsZCBtZXRob2QKPiA+ID4g dGhyb3VnaCB0aGUgQUNQSSBidWlsZGVyIG1ldGhvZHMuCj4gPiA+IE1vcmVvdmVyLCB3ZSB3aWxs IGFsc28gbmVlZCB0byByZWFjaCBidWlsZF9zcmF0KCkgZnJvbSBvdXRzaWRlIG9mCj4gPiA+IGFj cGktYnVpbGQgaW4gb3JkZXIgdG8gdXNlIGl0IGFzIHRoZSBBQ1BJIGJ1aWxkZXIgU1JBVCBidWls ZCBtZXRob2QuICAKPiA+IFNSQVQgaXMgdXN1YWxseSBoaWdobHkgbWFjaGluZSBzcGVjaWZpYyAo bWVtb3J5IGhvbGVzLCBsYXlvdXQsIGd1ZXN0IE9TCj4gPiBzcGVjaWZpYyBxdWlya3MpIHNvIGl0 J3MgaGFyZCB0byBnZW5lcmFsaXplIGl0LiAgCj4gSGVuY2UgdGhlIG5lZWQgZm9yIGFuIFNSQVQg YnVpbGRlciBpbnRlcmZhY2UuCnNvIGZhciBidWlsZGVyIGludGVyZmFjZSAodHJ5aW5nIHRvIGdl bmVyYWxpemUgYWNwaV9idWlsZCgpKSBsb29rcwpub3QgbmVjZXNzYXJ5LgpJJ2Qgc3VnZ2VzdCB0 byBkcm9wIGFuZCBjYWxsIGJ1aWxkX3N0YXJ0KCkgZGlyZWN0bHkuCgo+ID4gSSdkICBkcm9wIFNS QVQgcmVsYXRlZCBwYXRjaGVzIGZyb20gdGhpcyBzZXJpZXMgYW5kIGludHJvZHVjZQo+ID4gaTM4 Ni92aXJ0IHNwZWNpZmljIFNSQVQgd2hlbiB5b3UgcG9zdCBwYXRjaGVzIGZvciBpdC4gIAo+IHZp cnQgdXNlcyB0aGUgZXhpc3RpbmcgaTM4NiBidWlsZF9zcmF0KCkgcm91dGluZSwgdGhlcmUncyBu b3RoaW5nCj4gc3BlY2lhbCBhYm91dCBpdC4gU28gdGhpcyB3b3VsZCBiZSBwdXJlbHkgZHVwbGlj YXRlZCBjb2RlLgpMb29raW5nIGF0IGJ1aWxkX3NyYXQoKSwgaXQgaGFzIGEgYnVuY2ggb2YgY29k ZSB0byBoYW5kbGUgbGVnYWN5ClBDIGxheW91dC4gWW91IHByb2JhYmx5IGRvbid0IG5lZWQgYW55 IG9mIGl0IGZvciBuZXcgaXM4Ni92aXJ0Cm1hY2hpbmUgYW5kIGNhbiBtYWtlIHNpbXBsZXIgdmVy c2lvbiBvZiBpdC4KCkluIGFkZGl0aW9uIChwcm9iYWJseSByZXBlYXRpbmcgcXVlc3Rpb24gSSd2 ZSBhc2tlZCBlbHNld2hlcmUpLApEbyB5b3UgaGF2ZSB0byB1c2Ugc3BsaXQgaW5pdGlhbCBtZW1v cnkgbW9kZWwgZm9yIG5ldyBtYWNoaW5lPwpJcyBpdCBwb3NzaWJsZSB0byB1c2Ugb25seSBwYy1k aW1tcyBib3RoIGZvciBpbml0aWFsIGFuZCBob3RwbHVnZ2VkIG1lbW9yeQphdCBzb21lIGFkZHJl c3MgKDRHYj8pIHdpdGhvdXQgY3V0dGluZyBvdXQgUENJIGhvbGUgb3IgYW55IHRvaGVyIGhvbGVz IGluIFJBTSBsYXlvdXQ/Cgo+IENoZWVycywKPiBTYW11ZWwuCj4gCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRJ7P-00062P-9l for qemu-devel@nongnu.org; Mon, 26 Nov 2018 10:48:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRJ7O-0002DC-Dx for qemu-devel@nongnu.org; Mon, 26 Nov 2018 10:48:15 -0500 Date: Mon, 26 Nov 2018 16:47:51 +0100 From: Igor Mammedov Message-ID: <20181126164751.4e304b46@redhat.com> In-Reply-To: <20181121232733.GC4450@caravaggio> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-16-sameo@linux.intel.com> <20181115142854.1c62f32f@redhat.com> <20181121232733.GC4450@caravaggio> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Ortiz Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Richard Henderson On Thu, 22 Nov 2018 00:27:33 +0100 Samuel Ortiz wrote: > On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:38 +0100 > > Samuel Ortiz wrote: > > > > > This is the standard way of building SRAT on x86 platfoms. But future > > > machine types could decide to define their own custom SRAT build method > > > through the ACPI builder methods. > > > Moreover, we will also need to reach build_srat() from outside of > > > acpi-build in order to use it as the ACPI builder SRAT build method. > > SRAT is usually highly machine specific (memory holes, layout, guest OS > > specific quirks) so it's hard to generalize it. > Hence the need for an SRAT builder interface. so far builder interface (trying to generalize acpi_build()) looks not necessary. I'd suggest to drop and call build_start() directly. > > I'd drop SRAT related patches from this series and introduce > > i386/virt specific SRAT when you post patches for it. > virt uses the existing i386 build_srat() routine, there's nothing > special about it. So this would be purely duplicated code. Looking at build_srat(), it has a bunch of code to handle legacy PC layout. You probably don't need any of it for new is86/virt machine and can make simpler version of it. In addition (probably repeating question I've asked elsewhere), Do you have to use split initial memory model for new machine? Is it possible to use only pc-dimms both for initial and hotplugged memory at some address (4Gb?) without cutting out PCI hole or any toher holes in RAM layout? > Cheers, > Samuel. >