From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id D881E7D8A3 for ; Mon, 26 Nov 2018 19:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726786AbeK0GEL convert rfc822-to-8bit (ORCPT ); Tue, 27 Nov 2018 01:04:11 -0500 Received: from mail.bootlin.com ([62.4.15.54]:40202 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbeK0GEL (ORCPT ); Tue, 27 Nov 2018 01:04:11 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 4489A20711; Mon, 26 Nov 2018 20:09:06 +0100 (CET) Received: from bbrezillon (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 9AA6D20D2E; Mon, 26 Nov 2018 20:08:55 +0100 (CET) Date: Mon, 26 Nov 2018 20:08:55 +0100 From: Boris Brezillon To: vitor Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts Message-ID: <20181126200855.0caa45b0@bbrezillon> In-Reply-To: <20181126195618.352eafb1@bbrezillon> References: <20181122210202.6af50fcc@bbrezillon> <6d513e04-3a57-1989-429c-64631101c5a2@synopsys.com> <20181123135004.7fd1cd58@bbrezillon> <83115f47-1326-cb33-a7dc-4bc8ff95befa@synopsys.com> <20181126133550.51469816@bbrezillon> <4e9c0461-02a3-80b2-c9b7-2e9ea9b38f8b@synopsys.com> <20181126195618.352eafb1@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 26 Nov 2018 19:56:18 +0100 Boris Brezillon wrote: > > > >     - for the others it will easy the SoC integration avoiding > > duplicated work and doing things from scratch. > > What would be duplicated? You want to support a new SoC, just add a new > entry in the of_match_table and you're done. When you need to add > SoC/integration specific stuff, create a struct and attach a different > instance per-compatible so that each SoC can have its own configuration > (or even init sequence if needed). That's how we do for pretty much all > IPs out there, why should designware ones be different? To be more specific, I'd like a real example that shows why the separation is needed. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts Date: Mon, 26 Nov 2018 20:08:55 +0100 Message-ID: <20181126200855.0caa45b0@bbrezillon> References: <20181122210202.6af50fcc@bbrezillon> <6d513e04-3a57-1989-429c-64631101c5a2@synopsys.com> <20181123135004.7fd1cd58@bbrezillon> <83115f47-1326-cb33-a7dc-4bc8ff95befa@synopsys.com> <20181126133550.51469816@bbrezillon> <4e9c0461-02a3-80b2-c9b7-2e9ea9b38f8b@synopsys.com> <20181126195618.352eafb1@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20181126195618.352eafb1@bbrezillon> Sender: linux-kernel-owner@vger.kernel.org To: vitor Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de, psroka@cadence.com, agolec@cadence.com, adouglas@cadence.com, bfolta@cadence.com, dkos@cadence.com, alicja@cadence.com, cwronka@cadence.com, sureshp@cadence.com, rafalc@cadence.com, thomas.petazzoni@bootlin.com, nm@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org, linus.walleij@linaro.org, Xiang.Lin@synaptics.com, linux-gpio@vger.kernel.org, nsekhar@ti.com, pgaj@cadence.com, peda@axentia.se, mshettel@codeaurora.org, swboyd@chromium.org List-Id: linux-gpio@vger.kernel.org On Mon, 26 Nov 2018 19:56:18 +0100 Boris Brezillon wrote: > > > >     - for the others it will easy the SoC integration avoiding > > duplicated work and doing things from scratch. > > What would be duplicated? You want to support a new SoC, just add a new > entry in the of_match_table and you're done. When you need to add > SoC/integration specific stuff, create a struct and attach a different > instance per-compatible so that each SoC can have its own configuration > (or even init sequence if needed). That's how we do for pretty much all > IPs out there, why should designware ones be different? To be more specific, I'd like a real example that shows why the separation is needed.