From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yang Xiao <YangX92@hotmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"r.weclawski@gmail.com" <r.weclawski@gmail.com>,
"straube.linux@gmail.com" <straube.linux@gmail.com>,
"santhameena13@gmail.com" <santhameena13@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"jananis37@gmail.com" <jananis37@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c
Date: Tue, 27 Nov 2018 11:34:27 +0300 [thread overview]
Message-ID: <20181127083427.GS2970@unbuntlaptop> (raw)
In-Reply-To: <HK0PR01MB2163A0287797ECA3CDA68AA2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
On Tue, Nov 27, 2018 at 08:29:05AM +0000, Yang Xiao wrote:
> Hi,
>
> See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an
> off-by-one mistake in core/rtw_mlme_ext.c") for detail.
>
> I don't know how can you make sure that line 3254 can be true in the for
> loop. If the condition never satisfies, then there is an off-by-one
> access in line 3267.
>
> If you can prove it, then the patch is unnecessary.
>
Ugh... Patch ef9209b642f isn't right. :(
Do you want to send a patch to change that back to the way it was. If
not then I can do it.
regards,
dan carpenter
next prev parent reply other threads:[~2018-11-27 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HK0PR01MB216364A68D785B7EBC8DD43EADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 7:57 ` [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c gregkh
2018-11-27 8:15 ` Dan Carpenter
[not found] ` <HK0PR01MB2163A0287797ECA3CDA68AA2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 8:34 ` Dan Carpenter [this message]
[not found] ` <HK0PR01MB2163FB565C3ADD4BCE1FE7D2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 8:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127083427.GS2970@unbuntlaptop \
--to=dan.carpenter@oracle.com \
--cc=YangX92@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jananis37@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r.weclawski@gmail.com \
--cc=santhameena13@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.