From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver Date: Tue, 27 Nov 2018 13:10:43 -0500 Message-ID: <20181127131031-mutt-send-email-mst@kernel.org> References: <20181122193801.50510-1-jean-philippe.brucker@arm.com> <20181122193801.50510-6-jean-philippe.brucker@arm.com> <20181123164716-mutt-send-email-mst@kernel.org> <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> To: Jean-Philippe Brucker Cc: "iommu@lists.linux-foundation.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , "joro@8bytes.org" , Mark Rutland , Lorenzo Pieralisi , "tnowicki@caviumnetworks.com" , Marc Zyngier , Robin Murphy , Will Deacon , "eric.auger@redhat.com" , "robh+dt@kernel.org" , "bhelgaas@google.com" , "kvmarm@lists.cs.columbia.edu" List-Id: kvmarm@lists.cs.columbia.edu On Tue, Nov 27, 2018 at 05:58:18PM +0000, Jean-Philippe Brucker wrote: > On 23/11/2018 21:48, Michael S. Tsirkin wrote: > >> +struct virtio_iommu_config { > >> + /* Supported page sizes */ > >> + __u64 page_size_mask; > >> + /* Supported IOVA range */ > >> + struct virtio_iommu_range input_range; > >> + /* Max domain ID size */ > >> + __u8 domain_bits; > >> + __u8 padding[3]; > > > > Not enough padding here it seems. Structure is 8 byte > > aligned on 64 bit systems. > > The next field (probe_size) is 4 bytes, so the alignment ends up fine. > That field is introduced in patch 6, maybe I should move it here? > > Thanks, > Jean Sounds like a good idea. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5057-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 861CF985BBF for ; Tue, 27 Nov 2018 18:10:54 +0000 (UTC) Date: Tue, 27 Nov 2018 13:10:43 -0500 From: "Michael S. Tsirkin" Message-ID: <20181127131031-mutt-send-email-mst@kernel.org> References: <20181122193801.50510-1-jean-philippe.brucker@arm.com> <20181122193801.50510-6-jean-philippe.brucker@arm.com> <20181123164716-mutt-send-email-mst@kernel.org> <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0fed79f3-ca2e-b539-74f5-cd2a8091f65d@arm.com> Subject: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver To: Jean-Philippe Brucker Cc: "iommu@lists.linux-foundation.org" , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , "joro@8bytes.org" , Mark Rutland , Lorenzo Pieralisi , "tnowicki@caviumnetworks.com" , Marc Zyngier , Robin Murphy , Will Deacon , "eric.auger@redhat.com" , "robh+dt@kernel.org" , "bhelgaas@google.com" , "kvmarm@lists.cs.columbia.edu" List-ID: On Tue, Nov 27, 2018 at 05:58:18PM +0000, Jean-Philippe Brucker wrote: > On 23/11/2018 21:48, Michael S. Tsirkin wrote: > >> +struct virtio_iommu_config { > >> + /* Supported page sizes */ > >> + __u64 page_size_mask; > >> + /* Supported IOVA range */ > >> + struct virtio_iommu_range input_range; > >> + /* Max domain ID size */ > >> + __u8 domain_bits; > >> + __u8 padding[3]; > > > > Not enough padding here it seems. Structure is 8 byte > > aligned on 64 bit systems. > > The next field (probe_size) is 4 bytes, so the alignment ends up fine. > That field is introduced in patch 6, maybe I should move it here? > > Thanks, > Jean Sounds like a good idea. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org