From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-mm@kvack.org, "Kirill A . Shutemov" <kirill@shutemov.name>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] mm: warn only once if page table misaccounting is detected
Date: Tue, 27 Nov 2018 15:36:38 +0100 [thread overview]
Message-ID: <20181127143638.GE3625@osiris> (raw)
In-Reply-To: <20181127131916.GX12455@dhcp22.suse.cz>
On Tue, Nov 27, 2018 at 02:19:16PM +0100, Michal Hocko wrote:
> On Tue 27-11-18 09:36:03, Heiko Carstens wrote:
> > Use pr_alert_once() instead of pr_alert() if page table misaccounting
> > has been detected.
> >
> > If this happens once it is very likely that there will be numerous
> > other occurrence as well, which would flood dmesg and the console with
> > hardly any added information. Therefore print the warning only once.
>
> Have you actually experience a flood of these messages? Is one per mm
> message really that much?
Yes, I did. Since in this case all compat processes caused the message
to appear, I saw thousands of these messages.
> If yes why rss counters do not exhibit the same problem?
No rss counter messages appeared. Or do you suggest that the other
pr_alert() within check_mm() should also be changed?
next prev parent reply other threads:[~2018-11-27 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 8:36 [PATCH] mm: warn only once if page table misaccounting is detected Heiko Carstens
2018-11-27 8:46 ` Kirill A. Shutemov
2018-11-27 13:19 ` Michal Hocko
2018-11-27 14:36 ` Heiko Carstens [this message]
2018-11-27 16:29 ` Michal Hocko
2018-11-27 15:52 ` Sean Christopherson
2018-11-27 15:55 ` William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127143638.GE3625@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.