From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] encrypt in threads
Date: Tue, 27 Nov 2018 16:05:02 +0000 [thread overview]
Message-ID: <20181127160502.GI18381@redhat.com> (raw)
In-Reply-To: <1bc34791-6ae3-cbcd-222f-468b89205f64@virtuozzo.com>
On Wed, Nov 21, 2018 at 05:30:53PM +0000, Vladimir Sementsov-Ogievskiy wrote:
> Hi Daniel!
>
> After moving compression to threads in Qcow2 it's an obvious next step to
> "threadyfy" encryption in Qcow2 too.
>
> But it turned out to be not as simple as I assumed. If I call qcrypto_block_encrypt
> in parallel threads with the same first argument (block), it just produce wrong
> things (pattern verification fails in iotests)..
Yes, this makes sense, because the underlying crypto impls all require
that their state is only used from a single thread at any time. What's
likely happening is that the IV is being scrambled so we're encrypting
with the wrong tweak.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2018-11-27 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 17:30 [Qemu-devel] encrypt in threads Vladimir Sementsov-Ogievskiy
2018-11-22 13:01 ` Vladimir Sementsov-Ogievskiy
2018-11-27 16:08 ` Daniel P. Berrangé
2018-11-29 18:28 ` Vladimir Sementsov-Ogievskiy
2018-11-30 9:48 ` Daniel P. Berrangé
2018-11-30 10:04 ` Vladimir Sementsov-Ogievskiy
2018-11-30 10:19 ` Daniel P. Berrangé
2018-11-27 16:05 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127160502.GI18381@redhat.com \
--to=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.