From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH v10 20/23] i915/dp/fec: Add fec_enable to the crtc state. Date: Tue, 27 Nov 2018 09:46:04 -0800 Message-ID: <20181127174604.GI32069@intel.com> References: <20181120183736.28054-1-manasi.d.navare@intel.com> <20181120183736.28054-21-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181120183736.28054-21-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Anusha Srivatsa List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMjAsIDIwMTggYXQgMTA6Mzc6MzNBTSAtMDgwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBGcm9tOiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+ Cj4gCj4gRm9yIERQIDEuNCBhbmQgYWJvdmUsIERpc3BsYXkgU3RyZWFtIGNvbXByZXNzaW9uIGNh biBiZQo+IGVuYWJsZWQgb25seSBpZiBGb3J3YXJkIEVycm9yIENvcnJlY3RpbiBjYW4gYmUgcGVy Zm9ybWVkLgo+IAo+IEFkZCBhIGNydGMgc3RhdGUgZm9yIEZFQy4gQ3VycmVudGx5LCB0aGUgc3Rh dGUKPiBpcyBkZXRlcm1pbmVkIGJ5IHBsYXRmb3JtLCBEUCBhbmQgRFNDIGJlaW5nCj4gZW5hYmxl ZC4gTW92aW5nIGZvcndhcmQgd2UgY2FuIHVzZSB0aGUgc3RhdGUKPiB0byBoYXZlIGVycm9yIGNv cnJlY3Rpb24gb24gb3RoZXIgc2NlbmFyaW9zIHRvbwo+IGlmIG5lZWRlZC4KPiAKPiB2MjoKPiAt IENvbnRyb2wgY29tcHJlc3Npb25fZW5hYmxlIHdpdGggdGhlIGZlY19lbmFibGUKPiBwYXJhbWV0 ZXIgaW4gY3J0YyBzdGF0ZSBhbmQgd2l0aCBpbnRlbF9kcF9zdXBwb3J0c19mZWMoKQo+IChWaWxs ZSkKPiAKPiAtIGludGVsX2RwX2Nhbl9mZWMoKS9pbnRlbF9kcF9zdXBwb3J0c19mZWMoKShtYW5h c2kpCj4gCj4gdjM6IENoZWNrIGZvciBGRUMgc3VwcG9ydCBhbG9uZyB3aXRoIHNldHRpbmcgY3J0 YyBzdGF0ZS4KPiAKPiB2NDogYWRkIGNoZWNrcyB0byBpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNf ZHNjLihtYW5hc2kpCj4gLSBNb3ZlIGludGVsX2RwX3N1cHBvcnRzX2ZlYygpIGNsb3NlciB0bwo+ IGludGVsX2RwX3N1cHBvcnRzX2RzYygpIChBbnVzaGEpCj4gCj4gdjU6IE1vdmUgZmVjIGNoZWNr IHRvIGludGVsX2RwX3N1cHBvcnRzX2RzYyhWaWxsZSkKPiAKPiB2NjogUmVtb3ZlIHdhcm5pbmcu IHJlYmFzZS4KPiAKPiB2NzogY2hhbmdlIGNydGMgc3RhdGUgdG8gaW5jbHVkZSBEUCBzaW5rIGFu ZCBmZWMgY2FwYWJpbGl0eQo+IG9mIHNvdXJjZS4oTWFuYXNpKQo+IAo+IHY4OiBTZXQgZmVjX2Vu YWJsZSBpbiBjcnRjIGluIGludGVsX2RwX2NvbXB1dGVfY29uZmlnKCkuCj4gCj4gdjkgKEZyb20g TWFuYXNpKToKPiAqIENvbWJpbmUgdGhlICFlZHAgYW5kICFmZWNfc3VwcG9ydCBjaGVjawo+ICog RGVyaXZlIGRldl9wcml2IGZyb20gaW50ZWxfZHAgZGlyZWN0bHkKPiAKPiB2MTAgKEZyb20gTWFu YXNpKToKPiAqIFJlYmFzZQo+IAo+IFN1Z2dlc3RlZC1ieTogVmlsbGUgU3lyamFsYSA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1h bmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog QW51c2hhIFNyaXZhdHNhIDxhbnVzaGEuc3JpdmF0c2FAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6 IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+CgpNYW5hc2kKCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgMjcgKysrKysrKysrKysrKysr KysrKysrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIHwgIDMgKysr Cj4gIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA4YjE2OTRjNjMxYzcuLjk0YWRiZDk4OGI5 MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC01NDUsNyArNTQ1LDcgQEAgaW50 ZWxfZHBfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQlk c2Nfc2xpY2VfY291bnQgPQo+ICAJCQkJZHJtX2RwX2RzY19zaW5rX21heF9zbGljZV9jb3VudChp bnRlbF9kcC0+ZHNjX2RwY2QsCj4gIAkJCQkJCQkJdHJ1ZSk7Cj4gLQkJfSBlbHNlIHsKPiArCQl9 IGVsc2UgaWYgKGRybV9kcF9zaW5rX3N1cHBvcnRzX2ZlYyhpbnRlbF9kcC0+ZmVjX2NhcGFibGUp KSB7Cj4gIAkJCWRzY19tYXhfb3V0cHV0X2JwcCA9Cj4gIAkJCQlpbnRlbF9kcF9kc2NfZ2V0X291 dHB1dF9icHAobWF4X2xpbmtfY2xvY2ssCj4gIAkJCQkJCQkgICAgbWF4X2xhbmVzLAo+IEBAIC0x NzEwLDE0ICsxNzEwLDI1IEBAIHN0cnVjdCBsaW5rX2NvbmZpZ19saW1pdHMgewo+ICAJaW50IG1p bl9icHAsIG1heF9icHA7Cj4gIH07Cj4gIAo+IC1zdGF0aWMgYm9vbCBpbnRlbF9kcF9zb3VyY2Vf c3VwcG9ydHNfZHNjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gK3N0YXRpYyBib29sIGlu dGVsX2RwX3NvdXJjZV9zdXBwb3J0c19mZWMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAg CQkJCQkgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1KGludGVsX2Rw KTsKPiAgCj4gLQkvKiBGSVhNRTogRkVDIG5lZWRlZCBmb3IgZXh0ZXJuYWwgRFAgdW50aWwgdGhl biByZWplY3QgRFNDIG9uIERQICovCj4gLQlpZiAoIWludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkp Cj4gLQkJcmV0dXJuIGZhbHNlOwo+ICsJcmV0dXJuIElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEg JiYgcGlwZV9jb25maWctPmNwdV90cmFuc2NvZGVyICE9IFRSQU5TQ09ERVJfQTsKPiArfQo+ICsK PiArc3RhdGljIGJvb2wgaW50ZWxfZHBfc3VwcG9ydHNfZmVjKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAsCj4gKwkJCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZp ZykKPiArewo+ICsJcmV0dXJuIGludGVsX2RwX3NvdXJjZV9zdXBwb3J0c19mZWMoaW50ZWxfZHAs IHBpcGVfY29uZmlnKSAmJgo+ICsJCWRybV9kcF9zaW5rX3N1cHBvcnRzX2ZlYyhpbnRlbF9kcC0+ ZmVjX2NhcGFibGUpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgYm9vbCBpbnRlbF9kcF9zb3VyY2Vfc3Vw cG9ydHNfZHNjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gKwkJCQkJIGNvbnN0IHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiArewo+ICsJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZHBfdG9faTkxNShpbnRlbF9kcCk7Cj4gIAo+ICAJcmV0dXJu IElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTAgJiYKPiAgCQlwaXBlX2NvbmZpZy0+Y3B1X3RyYW5z Y29kZXIgIT0gVFJBTlNDT0RFUl9BOwo+IEBAIC0xNzI2LDYgKzE3MzcsOSBAQCBzdGF0aWMgYm9v bCBpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfZHNjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAs Cj4gIHN0YXRpYyBib29sIGludGVsX2RwX3N1cHBvcnRzX2RzYyhzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwLAo+ICAJCQkJICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25m aWcpCj4gIHsKPiArCWlmICghaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAmJiAhcGlwZV9jb25m aWctPmZlY19lbmFibGUpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiAgCXJldHVybiBpbnRlbF9k cF9zb3VyY2Vfc3VwcG9ydHNfZHNjKGludGVsX2RwLCBwaXBlX2NvbmZpZykgJiYKPiAgCQlkcm1f ZHBfc2lua19zdXBwb3J0c19kc2MoaW50ZWxfZHAtPmRzY19kcGNkKTsKPiAgfQo+IEBAIC0yMTI4 LDYgKzIxNDIsOSBAQCBpbnRlbF9kcF9jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlciwKPiAgCWlmIChhZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdf REJMQ0xLKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gKwlwaXBlX2NvbmZpZy0+ZmVjX2VuYWJs ZSA9ICFpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApICYmCj4gKwkJCQkgIGludGVsX2RwX3N1cHBv cnRzX2ZlYyhpbnRlbF9kcCwgcGlwZV9jb25maWcpOwo+ICsKPiAgCWlmICghaW50ZWxfZHBfY29t cHV0ZV9saW5rX2NvbmZpZyhlbmNvZGVyLCBwaXBlX2NvbmZpZywgY29ubl9zdGF0ZSkpCj4gIAkJ cmV0dXJuIGZhbHNlOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDkyZTk4 N2ZjM2Q5Zi4uMGRmZGRiOTA3ZjEwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBA QCAtOTQ1LDYgKzk0NSw5IEBAIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlIHsKPiAgCQl1OCBzbGlj ZV9jb3VudDsKPiAgCX0gZHNjX3BhcmFtczsKPiAgCXN0cnVjdCBkcm1fZHNjX2NvbmZpZyBkcF9k c2NfY2ZnOwo+ICsKPiArCS8qIEZvcndhcmQgRXJyb3IgY29ycmVjdGlvbiBTdGF0ZSAqLwo+ICsJ Ym9vbCBmZWNfZW5hYmxlOwo+ICB9Owo+ICAKPiAgc3RydWN0IGludGVsX2NydGMgewo+IC0tIAo+ IDIuMTkuMQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK