From: Thierry Reding <thierry.reding@gmail.com>
To: jun qian <hangdianqj@163.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-tegra: replace spin_lock_irqsave with spin_lock in ISR
Date: Wed, 28 Nov 2018 10:13:15 +0100 [thread overview]
Message-ID: <20181128091315.GA17419@ulmo> (raw)
In-Reply-To: <20180911145446.53621-1-hangdianqj@163.com>
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
On Tue, Sep 11, 2018 at 07:54:46AM -0700, jun qian wrote:
> As you are already in ISR, it is unnecessary to call spin_lock_irqsave.
>
> Signed-off-by: jun qian <hangdianqj@163.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-28 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 14:54 [PATCH] i2c: i2c-tegra: replace spin_lock_irqsave with spin_lock in ISR jun qian
2018-11-27 18:13 ` Dmitry Osipenko
2018-11-28 9:13 ` Thierry Reding [this message]
2018-12-11 19:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128091315.GA17419@ulmo \
--to=thierry.reding@gmail.com \
--cc=hangdianqj@163.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.