From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Date: Wed, 28 Nov 2018 17:32:01 +0000 Message-ID: <20181128173201.GD14786@perard.uk.xensource.com> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128171001.GC14786@perard.uk.xensource.com> <79c7ea5f1b8041d7828240ec18f881f4@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gS3hQ-0006VT-Iw for xen-devel@lists.xenproject.org; Wed, 28 Nov 2018 17:32:32 +0000 Content-Disposition: inline In-Reply-To: <79c7ea5f1b8041d7828240ec18f881f4@AMSPEX02CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Stefano Stabellini , Eduardo Habkost , "qemu-block@nongnu.org" , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Marcel Apfelbaum , Paolo Bonzini , "xen-devel@lists.xenproject.org" , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMjgsIDIwMTggYXQgMDU6MTc6MTBQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+ID4gV2lsbCB3ZSBuZWVkIGEgaG90cGx1ZyBoYW5kbGVyIGZvciB0aGlzIGJ1cywgbGlr ZSBpdCBpcyBkb25lIHdpdGgKPiA+IFRZUEVfWEVOU1lTQlVTPwo+IAo+IEkgZGlkbid0IHNlZW0g dG8gbmVlZCBvbmUgZXZlbiBkb2luZyAneGwgYmxvY2stYXR0YWNoJyBhZnRlciB0aGUgVk0gaGFk IGJvb3RlZC4gSSdtIHJlYWxseSBub3Qgc3VyZSB3aGF0IHRoYXQgZG9lcy4KCkluZGVlZCwgdGhh dCB3b3JrcyBmaW5lLCBhbmQgSSB0aGluayBJJ3ZlIHRlc3RlZCBibG9jay1kZXRhY2ggYXMgd2Vs bC4KTWF5YmUgd2Ugd2lsbCBuZWVkIHNvbWV0aGluZyBpZiB3ZSBpbml0aWF0ZSBhdHRhY2ggb2Yg YSBibG9jayBkZXZpY2UgdmlhClFNUCBpbnN0ZWFkIG9mIHhlbnN0b3JlLCBidXQgd2UgY2FuIGZp eCB0aGF0IGxhdGVyLgoKLS0gCkFudGhvbnkgUEVSQVJECgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxt YW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gS3xZ-0001VY-O6 for qemu-devel@nongnu.org; Wed, 28 Nov 2018 12:49:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gS3hV-0001TK-Hk for qemu-devel@nongnu.org; Wed, 28 Nov 2018 12:32:38 -0500 Date: Wed, 28 Nov 2018 17:32:01 +0000 From: Anthony PERARD Message-ID: <20181128173201.GD14786@perard.uk.xensource.com> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128171001.GC14786@perard.uk.xensource.com> <79c7ea5f1b8041d7828240ec18f881f4@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <79c7ea5f1b8041d7828240ec18f881f4@AMSPEX02CL03.citrite.net> Subject: Re: [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" , Stefano Stabellini , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost On Wed, Nov 28, 2018 at 05:17:10PM +0000, Paul Durrant wrote: > > Will we need a hotplug handler for this bus, like it is done with > > TYPE_XENSYSBUS? > > I didn't seem to need one even doing 'xl block-attach' after the VM had booted. I'm really not sure what that does. Indeed, that works fine, and I think I've tested block-detach as well. Maybe we will need something if we initiate attach of a block device via QMP instead of xenstore, but we can fix that later. -- Anthony PERARD