From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v4 08/21] rtc: mcp795: Switch to use %ptR
Date: Wed, 28 Nov 2018 21:05:24 +0200 [thread overview]
Message-ID: <20181128190537.14074-9-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181128190537.14074-1-andriy.shevchenko@linux.intel.com>
Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/rtc/rtc-mcp795.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c
index 00e11c1b2186..f22a945a3794 100644
--- a/drivers/rtc/rtc-mcp795.c
+++ b/drivers/rtc/rtc-mcp795.c
@@ -233,9 +233,7 @@ static int mcp795_set_time(struct device *dev, struct rtc_time *tim)
if (ret)
return ret;
- dev_dbg(dev, "Set mcp795: %04d-%02d-%02d(%d) %02d:%02d:%02d\n",
- tim->tm_year + 1900, tim->tm_mon, tim->tm_mday,
- tim->tm_wday, tim->tm_hour, tim->tm_min, tim->tm_sec);
+ dev_dbg(dev, "Set mcp795: %ptR\n", tim);
return 0;
}
@@ -258,9 +256,7 @@ static int mcp795_read_time(struct device *dev, struct rtc_time *tim)
tim->tm_mon = bcd2bin(data[5] & 0x1F) - 1;
tim->tm_year = bcd2bin(data[6]) + 100; /* Assume we are in 20xx */
- dev_dbg(dev, "Read from mcp795: %04d-%02d-%02d(%d) %02d:%02d:%02d\n",
- tim->tm_year + 1900, tim->tm_mon, tim->tm_mday,
- tim->tm_wday, tim->tm_hour, tim->tm_min, tim->tm_sec);
+ dev_dbg(dev, "Read from mcp795: %ptR\n", tim);
return 0;
}
@@ -319,9 +315,8 @@ static int mcp795_set_alarm(struct device *dev, struct rtc_wkalrm *alm)
return ret;
dev_dbg(dev, "Alarm IRQ armed\n");
}
- dev_dbg(dev, "Set alarm: %02d-%02d(%d) %02d:%02d:%02d\n",
- alm->time.tm_mon, alm->time.tm_mday, alm->time.tm_wday,
- alm->time.tm_hour, alm->time.tm_min, alm->time.tm_sec);
+ dev_dbg(dev, "Set alarm: %ptRdr(%d) %ptRt\n",
+ &alm->time, alm->time.tm_wday, &alm->time);
return 0;
}
@@ -345,9 +340,8 @@ static int mcp795_read_alarm(struct device *dev, struct rtc_wkalrm *alm)
alm->time.tm_isdst = -1;
alm->time.tm_yday = -1;
- dev_dbg(dev, "Read alarm: %02d-%02d(%d) %02d:%02d:%02d\n",
- alm->time.tm_mon, alm->time.tm_mday, alm->time.tm_wday,
- alm->time.tm_hour, alm->time.tm_min, alm->time.tm_sec);
+ dev_dbg(dev, "Read alarm: %ptRdr(%d) %ptRt\n",
+ &alm->time, alm->time.tm_wday, &alm->time);
return 0;
}
--
2.19.2
next prev parent reply other threads:[~2018-11-28 19:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 19:05 [PATCH v4 00/21] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 01/21] nvmem: Mark nvmem_type_str array with __maybe_unused Andy Shevchenko
2018-11-28 21:05 ` Alexandre Belloni
2018-11-29 0:10 ` Joe Perches
2018-11-28 19:05 ` [PATCH v4 02/21] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 03/21] rtc: Switch to use %ptR Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 04/21] rtc: at91rm9200: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 05/21] rtc: at91sam9: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 06/21] rtc: m41t80: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 07/21] rtc: m48t59: " Andy Shevchenko
2018-11-28 19:05 ` Andy Shevchenko [this message]
2018-11-28 19:05 ` [PATCH v4 09/21] rtc: pcf50633: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 10/21] rtc: pic32: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 11/21] rtc: pm8xxx: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 12/21] rtc: puv3: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 13/21] rtc: rk808: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 14/21] rtc: rx6110: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 15/21] rtc: rx8025: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 16/21] rtc: s3c: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 17/21] rtc: s5m: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 18/21] rtc: tegra: " Andy Shevchenko
2018-11-28 19:48 ` Thierry Reding
2018-11-28 19:05 ` [PATCH v4 19/21] Input: hp_sdc_rtc - " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 20/21] mk68/mac: " Andy Shevchenko
2018-11-29 9:08 ` Geert Uytterhoeven
2018-11-29 9:09 ` Geert Uytterhoeven
2018-11-28 19:05 ` [PATCH v4 21/21] PM: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128190537.14074-9-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=salyzyn@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.