diff for duplicates of <20181128231940.GB131170@gmail.com> diff --git a/a/1.txt b/N1/1.txt index ccd0510..e0bd165 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > -> syzbot hit the 'BUG_ON(index_key->desc_len = 0);' in __key_link_begin() +> syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > called from construct_alloc_key() during sys_request_key(), because the > length of the key description was never calculated. > @@ -48,8 +48,8 @@ On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > --- a/security/keys/keyring.c > +++ b/security/keys/keyring.c > @@ -661,9 +661,6 @@ static bool search_nested_keyrings(struct key *keyring, -> BUG_ON((ctx->flags & STATE_CHECKS) = 0 || -> (ctx->flags & STATE_CHECKS) = STATE_CHECKS); +> BUG_ON((ctx->flags & STATE_CHECKS) == 0 || +> (ctx->flags & STATE_CHECKS) == STATE_CHECKS); > > - if (ctx->index_key.description) > - ctx->index_key.desc_len = strlen(ctx->index_key.description); diff --git a/a/content_digest b/N1/content_digest index a157784..2134722 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020181103015854.7380-1-ebiggers@kernel.org\0" "From\0Eric Biggers <ebiggers@kernel.org>\0" "Subject\0Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len\0" - "Date\0Wed, 28 Nov 2018 23:19:41 +0000\0" + "Date\0Wed, 28 Nov 2018 15:19:41 -0800\0" "To\0keyrings@vger.kernel.org" " David Howells <dhowells@redhat.com>\0" "Cc\0linux-security-module@vger.kernel.org" @@ -13,7 +13,7 @@ "On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote:\n" "> From: Eric Biggers <ebiggers@google.com>\n" "> \n" - "> syzbot hit the 'BUG_ON(index_key->desc_len = 0);' in __key_link_begin()\n" + "> syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin()\n" "> called from construct_alloc_key() during sys_request_key(), because the\n" "> length of the key description was never calculated.\n" "> \n" @@ -60,8 +60,8 @@ "> --- a/security/keys/keyring.c\n" "> +++ b/security/keys/keyring.c\n" "> @@ -661,9 +661,6 @@ static bool search_nested_keyrings(struct key *keyring,\n" - "> \tBUG_ON((ctx->flags & STATE_CHECKS) = 0 ||\n" - "> \t (ctx->flags & STATE_CHECKS) = STATE_CHECKS);\n" + "> \tBUG_ON((ctx->flags & STATE_CHECKS) == 0 ||\n" + "> \t (ctx->flags & STATE_CHECKS) == STATE_CHECKS);\n" "> \n" "> -\tif (ctx->index_key.description)\n" "> -\t\tctx->index_key.desc_len = strlen(ctx->index_key.description);\n" @@ -124,4 +124,4 @@ "\n" - Eric -0f9f99c32299583c100a2184181ceeb99e1a18c3eee6f33de23c1f0debcf85c7 +65c94a5c7d2d57f372637bab845aa84ce8c7804f3078df2f63150604bdc0f301
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.