From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Date: Thu, 29 Nov 2018 10:04:38 +0100 Message-ID: <20181129090438.GB4797@linux.fritz.box> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128161917.GE4222@dhcp-200-186.str.redhat.com> <48596f1fe100419c8b28ed54bda0117b@AMSPEX02CL03.citrite.net> <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> <20181128163900.GG4222@dhcp-200-186.str.redhat.com> <5327ba765089439caf8119de49c3a399@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gSIFa-00034s-MM for xen-devel@lists.xenproject.org; Thu, 29 Nov 2018 09:04:46 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: 'Stefano Stabellini' , 'Eduardo Habkost' , "'qemu-block@nongnu.org'" , "'Michael S. Tsirkin'" , "'qemu-devel@nongnu.org'" , 'Marcel Apfelbaum' , 'Paolo Bonzini' , Anthony Perard , "'xen-devel@lists.xenproject.org'" , 'Richard Henderson' List-Id: xen-devel@lists.xenproject.org QW0gMjguMTEuMjAxOCB1bSAxNzo0NiBoYXQgUGF1bCBEdXJyYW50IGdlc2NocmllYmVuOgo+ID4g LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IFBhdWwgRHVycmFudAo+ID4gU2Vu dDogMjggTm92ZW1iZXIgMjAxOCAxNjo0Ngo+ID4gVG86ICdLZXZpbiBXb2xmJyA8a3dvbGZAcmVk aGF0LmNvbT4KPiA+IENjOiAnU3RlZmFubyBTdGFiZWxsaW5pJyA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz47IHFlbXUtYmxvY2tAbm9uZ251Lm9yZzsKPiA+IHFlbXUtZGV2ZWxAbm9uZ251Lm9yZzsg eGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBFZHVhcmRvIEhhYmtvc3QKPiA+IDxlaGFi a29zdEByZWRoYXQuY29tPjsgTWljaGFlbCBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNvbT47IE1h cmNlbAo+ID4gQXBmZWxiYXVtIDxtYXJjZWwuYXBmZWxiYXVtQGdtYWlsLmNvbT47IEFudGhvbnkg UGVyYXJkCj4gPiA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT47IFBhb2xvIEJvbnppbmkgPHBi b256aW5pQHJlZGhhdC5jb20+OyBSaWNoYXJkCj4gPiBIZW5kZXJzb24gPHJ0aEB0d2lkZGxlLm5l dD4KPiA+IFN1YmplY3Q6IFJFOiBbUWVtdS1ibG9ja10gW1BBVENIIDAyLzE4XSB4ZW46IGludHJv ZHVjZSBuZXcgJ1hlbkJ1cycgYW5kCj4gPiAnWGVuRGV2aWNlJyBvYmplY3QgaGllcmFyY2h5Cj4g PiAKPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+ID4gRnJvbTogS2V2aW4gV29s ZiBbbWFpbHRvOmt3b2xmQHJlZGhhdC5jb21dCj4gPiA+IFNlbnQ6IDI4IE5vdmVtYmVyIDIwMTgg MTY6MzkKPiA+ID4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+Cj4g PiA+IENjOiAnU3RlZmFubyBTdGFiZWxsaW5pJyA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHFl bXUtCj4gPiBibG9ja0Bub25nbnUub3JnOwo+ID4gPiBxZW11LWRldmVsQG5vbmdudS5vcmc7IHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgRWR1YXJkbyBIYWJrb3N0Cj4gPiA+IDxlaGFi a29zdEByZWRoYXQuY29tPjsgTWljaGFlbCBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNvbT47IE1h cmNlbAo+ID4gPiBBcGZlbGJhdW0gPG1hcmNlbC5hcGZlbGJhdW1AZ21haWwuY29tPjsgQW50aG9u eSBQZXJhcmQKPiA+ID4gPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+OyBQYW9sbyBCb256aW5p IDxwYm9uemluaUByZWRoYXQuY29tPjsKPiA+IFJpY2hhcmQKPiA+ID4gSGVuZGVyc29uIDxydGhA dHdpZGRsZS5uZXQ+Cj4gPiA+IFN1YmplY3Q6IFJlOiBbUWVtdS1ibG9ja10gW1BBVENIIDAyLzE4 XSB4ZW46IGludHJvZHVjZSBuZXcgJ1hlbkJ1cycgYW5kCj4gPiA+ICdYZW5EZXZpY2UnIG9iamVj dCBoaWVyYXJjaHkKPiA+ID4KPiA+ID4gQW0gMjguMTEuMjAxOCB1bSAxNzoyOSBoYXQgUGF1bCBE dXJyYW50IGdlc2NocmllYmVuOgo+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0K PiA+ID4gPiA+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSBbbWFpbHRvOnNzdGFiZWxsaW5pQGtl cm5lbC5vcmddCj4gPiA+ID4gPiBTZW50OiAyOCBOb3ZlbWJlciAyMDE4IDE2OjI4Cj4gPiA+ID4g PiBUbzogUGF1bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT4KPiA+ID4gPiA+IENj OiAnS2V2aW4gV29sZicgPGt3b2xmQHJlZGhhdC5jb20+OyBxZW11LWJsb2NrQG5vbmdudS5vcmc7 IHFlbXUtCj4gPiA+ID4gPiBkZXZlbEBub25nbnUub3JnOyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmc7IFN0ZWZhbm8gU3RhYmVsbGluaQo+ID4gPiA+ID4gPHNzdGFiZWxsaW5pQGtlcm5l bC5vcmc+OyBFZHVhcmRvIEhhYmtvc3QgPGVoYWJrb3N0QHJlZGhhdC5jb20+Owo+ID4gPiBNaWNo YWVsCj4gPiA+ID4gPiBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNvbT47IE1hcmNlbCBBcGZlbGJh dW0KPiA+ID4gPiA+IDxtYXJjZWwuYXBmZWxiYXVtQGdtYWlsLmNvbT47IEFudGhvbnkgUGVyYXJk Cj4gPiA+IDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPjsKPiA+ID4gPiA+IFBhb2xvIEJvbnpp bmkgPHBib256aW5pQHJlZGhhdC5jb20+OyBSaWNoYXJkIEhlbmRlcnNvbgo+ID4gPiA8cnRoQHR3 aWRkbGUubmV0Pgo+ID4gPiA+ID4gU3ViamVjdDogUkU6IFtRZW11LWJsb2NrXSBbUEFUQ0ggMDIv MThdIHhlbjogaW50cm9kdWNlIG5ldyAnWGVuQnVzJwo+ID4gPiBhbmQKPiA+ID4gPiA+ICdYZW5E ZXZpY2UnIG9iamVjdCBoaWVyYXJjaHkKPiA+ID4gPiA+Cj4gPiA+ID4gPiBPbiBXZWQsIDI4IE5v diAyMDE4LCBQYXVsIER1cnJhbnQgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0KPiA+ID4gPiA+ID4gPiBGcm9tOiBLZXZpbiBXb2xmIFttYWlsdG86a3dvbGZA cmVkaGF0LmNvbV0KPiA+ID4gPiA+ID4gPiBTZW50OiAyOCBOb3ZlbWJlciAyMDE4IDE2OjE5Cj4g PiA+ID4gPiA+ID4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+Cj4g PiA+ID4gPiA+ID4gQ2M6IHFlbXUtYmxvY2tAbm9uZ251Lm9yZzsgcWVtdS1kZXZlbEBub25nbnUu b3JnOyB4ZW4tCj4gPiA+ID4gPiA+ID4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7IFN0ZWZh bm8gU3RhYmVsbGluaQo+ID4gPiA+ID4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Owo+ID4gPiA+ ID4gPiA+IEVkdWFyZG8gSGFia29zdCA8ZWhhYmtvc3RAcmVkaGF0LmNvbT47IE1pY2hhZWwgUy4g VHNpcmtpbgo+ID4gPiA+ID4gPiA+IDxtc3RAcmVkaGF0LmNvbT47IE1hcmNlbCBBcGZlbGJhdW0g PG1hcmNlbC5hcGZlbGJhdW1AZ21haWwuY29tPjsKPiA+ID4gPiA+IEFudGhvbnkKPiA+ID4gPiA+ ID4gPiBQZXJhcmQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+OyBQYW9sbyBCb256aW5pCj4g PiA+ID4gPiA8cGJvbnppbmlAcmVkaGF0LmNvbT47Cj4gPiA+ID4gPiA+ID4gUmljaGFyZCBIZW5k ZXJzb24gPHJ0aEB0d2lkZGxlLm5ldD4KPiA+ID4gPiA+ID4gPiBTdWJqZWN0OiBSZTogW1FlbXUt YmxvY2tdIFtQQVRDSCAwMi8xOF0geGVuOiBpbnRyb2R1Y2UgbmV3Cj4gPiA+ICdYZW5CdXMnCj4g PiA+ID4gPiBhbmQKPiA+ID4gPiA+ID4gPiAnWGVuRGV2aWNlJyBvYmplY3QgaGllcmFyY2h5Cj4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBBbSAyMS4xMS4yMDE4IHVtIDE2OjExIGhhdCBQYXVs IER1cnJhbnQgZ2VzY2hyaWViZW46Cj4gPiA+ID4gPiA+ID4gPiBUaGlzIHBhdGNoIGFkZHMgdGhl IGJhc2ljIGJvaWxlcnBsYXRlIGZvciBhICdYZW5CdXMnIG9iamVjdAo+ID4gdGhhdAo+ID4gPiA+ ID4gd2lsbAo+ID4gPiA+ID4gPiA+IGFjdAo+ID4gPiA+ID4gPiA+ID4gYXMgYSBwYXJlbnQgdG8g J1hlbkRldmljZScgUFYgYmFja2VuZHMuCj4gPiA+ID4gPiA+ID4gPiBBIG5ldyAnWGVuQnJpZGdl JyBvYmplY3QgaXMgYWxzbyBhZGRlZCB0byBjb25uZWN0IFhlbkJ1cyB0bwo+ID4gdGhlCj4gPiA+ ID4gPiBzeXN0ZW0KPiA+ID4gPiA+ID4gPiBidXMuCj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiA+ID4gVGhlIFhlbkJ1cyBvYmplY3QgaXMgaW5zdGFudGlhdGVkIGJ5IGEgbmV3IHhlbl9idXNf aW5pdCgpCj4gPiA+IGZ1bmN0aW9uCj4gPiA+ID4gPiA+ID4gY2FsbGVkCj4gPiA+ID4gPiA+ID4g PiBmcm9tIHRoZSBzYW1lIHNpdGVzIGFzIHRoZSBsZWdhY3kgeGVuX2JlX2luaXQoKSBmdW5jdGlv bi4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiBTdWJzZXF1ZW50IHBhdGNoZXMgd2ls bCBmbGVzaC1vdXQgdGhlIGZ1bmN0aW9uYWxpdHkgb2YgdGhlc2UKPiA+ID4gPiA+IG9iamVjdHMu Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJy YW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ ID4gZGlmZiAtLWdpdCBhL2h3L3hlbi94ZW4tYnVzLmMgYi9ody94ZW4veGVuLWJ1cy5jCj4gPiA+ ID4gPiA+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gPiA+ID4gPiA+ID4gaW5kZXggMDAw MDAwMDAwMC4uZGVkZTJkOTE0YQo+ID4gPiA+ID4gPiA+ID4gLS0tIC9kZXYvbnVsbAo+ID4gPiA+ ID4gPiA+ID4gKysrIGIvaHcveGVuL3hlbi1idXMuYwo+ID4gPiA+ID4gPiA+ID4gQEAgLTAsMCAr MSwxMjUgQEAKPiA+ID4gPiA+ID4gPiA+ICsvKgo+ID4gPiA+ID4gPiA+ID4gKyAqIENvcHlyaWdo dCAoYykgQ2l0cml4IFN5c3RlbXMgSW5jLgo+ID4gPiA+ID4gPiA+ID4gKyAqIEFsbCByaWdodHMg cmVzZXJ2ZWQuCj4gPiA+ID4gPiA+ID4gPiArICovCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4g PiBUaGlzIGRvZXNuJ3QgbG9vayB2ZXJ5IGNvbXBhdGlibGUgd2l0aCB0aGUgR1BMLiBJbiBmYWN0 IGl0IG1pZ2h0Cj4gPiA+IGV2ZW4KPiA+ID4gPiA+ID4gPiBtYWtlIGl0IGlsbGVnYWwgZm9yIHRo ZSBRRU1VIHByb2plY3QgdG8gZGlzdHJpYnV0ZSB0aGlzIGNvZGUuIDotCj4gPiApCj4gPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gPiBPdGhlciBmaWxlcyB5b3UgYWRkIHRocm91Z2hvdXQgdGhlIHNl cmllcyBzZWVtIHRvIGhhdmUgdGhlIHNhbWUKPiA+ID4gPiA+IHByb2JsZW0uCj4gPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gSSB3YXMgd29ya2luZyBvbiB0aGUgYXNzdW1wdGlv biB0aGF0IGEgbGFjayBvZiBleHBsaWNpdCBsaWNlbnNlCj4gPiA+IG1lYW50Cj4gPiA+ID4gPiB0 aGF0IHRoZSBvdmVyYWxsIHByb2plY3QgbGljZW5zZSBhcyBkZXNjcmliZWQgaW4gaXRlbSAyIGlu IExJQ0VOU0UuCj4gPiA+IERpZCBJCj4gPiA+ID4gPiBtaXNpbnRlcnByZXQgdGhhdCB0ZXh0Pwo+ ID4gPiA+ID4KPiA+ID4gPiA+IEl0J3MgIkFsbCByaWdodHMgcmVzZXJ2ZWQuIiB0aGUgcHJvYmxl bQo+ID4gPiA+Cj4gPiA+ID4gT2gsIEkgc2VlLiBJJ20gaGFwcHkgdG8gcmVtb3ZlIHRoYXQuCj4g PiA+Cj4gPiA+IFRoYXQgd291bGQgYmUgYmV0dGVyIGF0IGxlYXN0LiBJJ20gbm90IHN1cmUgYWJv dXQgZmlsZXMgdGhhdCBoYXZlIGEKPiA+ID4gY29weXJpZ2h0IGhlYWRlciwgYnV0IG5vIGxpY2Vu c2Ugc3RhdGVtZW50LiBEbyBzdWNoIGZpbGVzIGV4aXN0IHlldCBpbgo+ID4gPiB0aGUgc291cmNl IHRyZWU/Cj4gPiAKPiA+IFllcywgdGhlcmUncyBxdWl0ZSBhIGZldy4uLiBlLmcuIChmaXJzdCBv bmVzIEkgdHJpcHBlZCBvdmVyKQo+ID4gaHcvcmRtYS9yZG1hX2JhY2tlbmQuYywgaHcvdmlydGlv L3Zob3N0LWJhY2tlbmQuYywgLi4uCj4gCj4gT2guLi4gSSBzZWUgdGhleSBoYXZlIGEgbGljZW5z ZSBzdGF0ZW1lbnQgYnV0IG5vIGJvaWxlcnBsYXRlLi4uIGlzCj4gdGhhdCBzdGF0ZW1lbnQgZW5v dWdoPwoKWWVzLCB0aGlzIGlzIGdvb2QgZW5vdWdoLgoKPiA+ID4gVG8gYmUgb24gdGhlIHNhZmUg c2lkZSwgSSdkIGp1c3Qgc3RpY2sgd2l0aCB0aGUKPiA+ID4gZXN0YWJsaXNoZWQgcHJhY3RpY2Us IHdoaWNoIGlzIGhhdmluZyBhIGxpY2Vuc2UgaGVhZGVyIGluIGV2ZXJ5IGZpbGUuCj4gPiAKPiA+ IE9rLi4uIGlmIHRoYXQgaXMgZXN0YWJsaXNoZWQgcHJhY3RpY2UuIEl0IHJlYWxseSB3YXNuJ3Qg Y2xlYXIuCj4gPiAKPiA+ID4KPiA+ID4gQnkgdGhlIHdheSwgaW4gYSBsYXRlciBwYXRjaCB5b3Ug cmVtb3ZlIHRoZSBleGlzdGluZyBsaWNlbnNlIGhlYWRlciwKPiA+ID4gd2hpY2ggaXMgZGlmZmVy ZW50IGZyb20gdGhlIGRlZmF1bHQgbGljZW5zZSAoYmVjYXVzZSBwYXJ0cyBvZiB0aGUgc291cmNl Cj4gPiA+IGZpbGUgYXJlIEdQTCAyIG9ubHkpLiBJZiB5b3UgY2FuJ3QgcHJvdmUgdGhhdCBhbGwg c3VjaCBwYXJ0cyAoYW5kIHBhcnRzCj4gPiA+IGRlcml2ZWQgZnJvbSB0aGVtKSBoYXZlIGJlZW4g cmVtb3ZlZCwgdGhpcyBpcyBhbHNvIGEgcHJvYmxlbS4KPiA+ID4KPiA+IAo+ID4gV2hhdCBzaG91 bGQgSSBkbz8gSSBhbSBkdXBsaWNhdGluZyB4ZW5fZGlzaywgYW5kIHRoZW4gaGVhdmlseSBtb2Rp ZnlpbmcKPiA+IGl0LiBTaG91bGQgSSBqdXN0IGxlYXZlIHRoZSBvbGQgYm9pbGVycGxhdGUgaW4g cGxhY2U/CgpZZXMuIEZlZWwgZnJlZSB0byBhZGQgeW91ciBvd24gY29weXJpZ2h0IGxpbmUgcmln aHQgYmVsb3cgR2VyZCdzLCBidXQKbGVhdmUgdGhlIG9sZCBzdHVmZiBpbnRhY3QuCgpLZXZpbgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSIFn-000670-48 for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:05:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSIFj-00056i-4j for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:04:59 -0500 Date: Thu, 29 Nov 2018 10:04:38 +0100 From: Kevin Wolf Message-ID: <20181129090438.GB4797@linux.fritz.box> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128161917.GE4222@dhcp-200-186.str.redhat.com> <48596f1fe100419c8b28ed54bda0117b@AMSPEX02CL03.citrite.net> <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> <20181128163900.GG4222@dhcp-200-186.str.redhat.com> <5327ba765089439caf8119de49c3a399@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: 'Stefano Stabellini' , "'qemu-block@nongnu.org'" , "'qemu-devel@nongnu.org'" , "'xen-devel@lists.xenproject.org'" , 'Eduardo Habkost' , "'Michael S. Tsirkin'" , 'Marcel Apfelbaum' , Anthony Perard , 'Paolo Bonzini' , 'Richard Henderson' Am 28.11.2018 um 17:46 hat Paul Durrant geschrieben: > > -----Original Message----- > > From: Paul Durrant > > Sent: 28 November 2018 16:46 > > To: 'Kevin Wolf' > > Cc: 'Stefano Stabellini' ; qemu-block@nongnu.org; > > qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Eduardo Habkost > > ; Michael S. Tsirkin ; Marcel > > Apfelbaum ; Anthony Perard > > ; Paolo Bonzini ; Richard > > Henderson > > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > 'XenDevice' object hierarchy > > > > > -----Original Message----- > > > From: Kevin Wolf [mailto:kwolf@redhat.com] > > > Sent: 28 November 2018 16:39 > > > To: Paul Durrant > > > Cc: 'Stefano Stabellini' ; qemu- > > block@nongnu.org; > > > qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Eduardo Habkost > > > ; Michael S. Tsirkin ; Marcel > > > Apfelbaum ; Anthony Perard > > > ; Paolo Bonzini ; > > Richard > > > Henderson > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > > 'XenDevice' object hierarchy > > > > > > Am 28.11.2018 um 17:29 hat Paul Durrant geschrieben: > > > > > -----Original Message----- > > > > > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > > > > > Sent: 28 November 2018 16:28 > > > > > To: Paul Durrant > > > > > Cc: 'Kevin Wolf' ; qemu-block@nongnu.org; qemu- > > > > > devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano Stabellini > > > > > ; Eduardo Habkost ; > > > Michael > > > > > S. Tsirkin ; Marcel Apfelbaum > > > > > ; Anthony Perard > > > ; > > > > > Paolo Bonzini ; Richard Henderson > > > > > > > > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' > > > and > > > > > 'XenDevice' object hierarchy > > > > > > > > > > On Wed, 28 Nov 2018, Paul Durrant wrote: > > > > > > > -----Original Message----- > > > > > > > From: Kevin Wolf [mailto:kwolf@redhat.com] > > > > > > > Sent: 28 November 2018 16:19 > > > > > > > To: Paul Durrant > > > > > > > Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; xen- > > > > > > > devel@lists.xenproject.org; Stefano Stabellini > > > > > ; > > > > > > > Eduardo Habkost ; Michael S. Tsirkin > > > > > > > ; Marcel Apfelbaum ; > > > > > Anthony > > > > > > > Perard ; Paolo Bonzini > > > > > ; > > > > > > > Richard Henderson > > > > > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new > > > 'XenBus' > > > > > and > > > > > > > 'XenDevice' object hierarchy > > > > > > > > > > > > > > Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben: > > > > > > > > This patch adds the basic boilerplate for a 'XenBus' object > > that > > > > > will > > > > > > > act > > > > > > > > as a parent to 'XenDevice' PV backends. > > > > > > > > A new 'XenBridge' object is also added to connect XenBus to > > the > > > > > system > > > > > > > bus. > > > > > > > > > > > > > > > > The XenBus object is instantiated by a new xen_bus_init() > > > function > > > > > > > called > > > > > > > > from the same sites as the legacy xen_be_init() function. > > > > > > > > > > > > > > > > Subsequent patches will flesh-out the functionality of these > > > > > objects. > > > > > > > > > > > > > > > > Signed-off-by: Paul Durrant > > > > > > > > > > > > > > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > > > > > > > > new file mode 100644 > > > > > > > > index 0000000000..dede2d914a > > > > > > > > --- /dev/null > > > > > > > > +++ b/hw/xen/xen-bus.c > > > > > > > > @@ -0,0 +1,125 @@ > > > > > > > > +/* > > > > > > > > + * Copyright (c) Citrix Systems Inc. > > > > > > > > + * All rights reserved. > > > > > > > > + */ > > > > > > > > > > > > > > This doesn't look very compatible with the GPL. In fact it might > > > even > > > > > > > make it illegal for the QEMU project to distribute this code. :- > > ) > > > > > > > > > > > > > > Other files you add throughout the series seem to have the same > > > > > problem. > > > > > > > > > > > > > > > > > > > I was working on the assumption that a lack of explicit license > > > meant > > > > > that the overall project license as described in item 2 in LICENSE. > > > Did I > > > > > misinterpret that text? > > > > > > > > > > It's "All rights reserved." the problem > > > > > > > > Oh, I see. I'm happy to remove that. > > > > > > That would be better at least. I'm not sure about files that have a > > > copyright header, but no license statement. Do such files exist yet in > > > the source tree? > > > > Yes, there's quite a few... e.g. (first ones I tripped over) > > hw/rdma/rdma_backend.c, hw/virtio/vhost-backend.c, ... > > Oh... I see they have a license statement but no boilerplate... is > that statement enough? Yes, this is good enough. > > > To be on the safe side, I'd just stick with the > > > established practice, which is having a license header in every file. > > > > Ok... if that is established practice. It really wasn't clear. > > > > > > > > By the way, in a later patch you remove the existing license header, > > > which is different from the default license (because parts of the source > > > file are GPL 2 only). If you can't prove that all such parts (and parts > > > derived from them) have been removed, this is also a problem. > > > > > > > What should I do? I am duplicating xen_disk, and then heavily modifying > > it. Should I just leave the old boilerplate in place? Yes. Feel free to add your own copyright line right below Gerd's, but leave the old stuff intact. Kevin