All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: fix uninitialized completion when USB3 port got wrong status
Date: Thu, 29 Nov 2018 13:18:25 +0100	[thread overview]
Message-ID: <20181129121825.GA3149@kroah.com> (raw)
In-Reply-To: <1543479601-6248-1-git-send-email-aaron.ma@canonical.com>

On Thu, Nov 29, 2018 at 04:20:01PM +0800, Aaron Ma wrote:
> commit 958c0bd86075d4ef1c936998deefe1947e539240 upstream.
> 
> Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on
> Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3,
> after clear port reset it works fine.
> 
> Since this device is registered on USB3 roothub at boot,
> when port status reports not superspeed, xhci_get_port_status will call
> an uninitialized completion in bus_state[0].
> Kernel will hang because of NULL pointer.
> 
> Restrict the USB2 resume status check in USB2 roothub to fix hang issue.
> 
> Cc: stable@vger.kernel.org # 4.17.x-

Didn't work on 4.14.y, but I fixed it up there by hand...

thanks,

greg k-h

      reply	other threads:[~2018-11-29 23:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  8:20 [PATCH] usb: xhci: fix uninitialized completion when USB3 port got wrong status Aaron Ma
2018-11-29 12:18 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129121825.GA3149@kroah.com \
    --to=greg@kroah.com \
    --cc=aaron.ma@canonical.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.