All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] grpc: new package
Date: Thu, 29 Nov 2018 22:12:26 +0100	[thread overview]
Message-ID: <20181129221226.2beef795@windsurf> (raw)
In-Reply-To: <20181129062140.10474-2-robertroyrose@gmail.com>

Hello,

On Wed, 28 Nov 2018 22:21:40 -0800, Robert Rose wrote:
> Signed-off-by: Robert Rose <robertroyrose@gmail.com>
> ---
>  DEVELOPERS                                    |  3 ++
>  package/Config.in                             |  1 +
>  .../0001-target-build-using-host-plugin.patch | 44 +++++++++++++++++++
>  package/grpc/Config.in                        | 11 +++++
>  package/grpc/grpc.hash                        |  5 +++
>  package/grpc/grpc.mk                          | 36 +++++++++++++++
>  6 files changed, 100 insertions(+)
>  create mode 100644 package/grpc/0001-target-build-using-host-plugin.patch
>  create mode 100644 package/grpc/Config.in
>  create mode 100644 package/grpc/grpc.hash
>  create mode 100644 package/grpc/grpc.mk

Thanks for this new iteration. However, it's a pity that you didn't
reuse any of the improvements I had, and which I suggested you to
re-use for your next iteration.

So, I redid the same changes, and also improved the description of
0001-target-build-using-host-plugin.patch which was really not
sufficient.

Here is the list of changes I did:

    [Thomas:
     - add missing Config.in dependencies inherited from
       BR2_PACKAGE_PROTOBUF, as well as the corresponding Config.in
       comment
     - replace spaces by tabs in grpc.mk indentation
     - remove superfluous GRPC_SOURCE variable
     - improved patch description.]

After those changes, I applied this patch to next. Thanks for your
contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-29 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  6:21 [Buildroot] [PATCH v4 1/2] c-ares: support host build Robert Rose
2018-11-29  6:21 ` [Buildroot] [PATCH v4 2/2] grpc: new package Robert Rose
2018-11-29 21:12   ` Thomas Petazzoni [this message]
2018-12-03 16:00     ` Yann E. MORIN
2018-12-03 19:34       ` Matthew Weber
2018-11-29 21:10 ` [Buildroot] [PATCH v4 1/2] c-ares: support host build Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2018-11-29  6:17 Robert Rose
2018-11-29  6:17 ` [Buildroot] [PATCH v4 2/2] grpc: new package Robert Rose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129221226.2beef795@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.