From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: support debug mode
Date: Thu, 29 Nov 2018 23:05:54 +0100 [thread overview]
Message-ID: <20181129230554.079f209a@windsurf> (raw)
In-Reply-To: <1542900158-17272-1-git-send-email-etienne.carriere@linaro.org>
Hello,
On Thu, 22 Nov 2018 16:22:38 +0100, Etienne Carriere wrote:
> When the trusted firmware is built with debug support (DEBUG defined),
> the generated images are located at a specific path. The non debug
> images are located in generated directory build/<platform>/release/
> while the debug images are located in generated directory
> build/<platform>/debug/.
>
> This change introduces boolean BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
> to define whether the release or debug configuration is used to build
> trusted firmware. Note that enabling trusted firmware debug support, i.e
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="... DEBUG=1 ..."
> without enabling BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG will fail since
> buildroot will get generated files from the wrong path.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
What is this debug mode doing exactly ?
We already have a global BR2_ENABLE_DEBUG option to enable building
with debugging symbols. I am wondering if we should use that option as
well, or like you did, introduce a separate option. Perhaps for
something like ATF, that is very low-level and HW-specific, a separate
debug option is OK.
> +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
> + bool "Debug mode of the trusted firmware"
> + default n
"default n" is not needed, since it's the default. Not need to resend
just for that, we can fixup when applying.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-29 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 15:22 [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: support debug mode Etienne Carriere
2018-11-29 22:05 ` Thomas Petazzoni [this message]
2018-11-30 9:07 ` Etienne Carriere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129230554.079f209a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.