From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
jcody@redhat.com, pbonzini@redhat.com, dplotnikov@virtuozzo.com,
den@openvz.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] iotests: simple mirror test with kvm on 1G image
Date: Fri, 30 Nov 2018 13:19:47 +0100 [thread overview]
Message-ID: <20181130121947.GD5106@localhost.localdomain> (raw)
In-Reply-To: <20181129101801.6421-3-vsementsov@virtuozzo.com>
Am 29.11.2018 um 11:18 hat Vladimir Sementsov-Ogievskiy geschrieben:
> This test is broken without previous commit fixing dead-lock in mirror.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--- /home/kwolf/source/qemu/tests/qemu-iotests/235.out 2018-11-30 12:57:11.275937057 +0100
+++ /home/kwolf/source/qemu/tests/qemu-iotests/235.out.bad 2018-11-30 13:17:33.890988974 +0100
@@ -1 +1 @@
-{u'return': {}}
+{'return': {}}
Failures: 235
Failed 1 of 1 tests
I think this is because you use print() (which produces output that is
inconsistent between Python 2 and 3) instead of iotests.log().
Kevin
next prev parent reply other threads:[~2018-11-30 12:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:17 [Qemu-devel] [PATCH v2 0/2] mirror dead-lock Vladimir Sementsov-Ogievskiy
2018-11-29 10:18 ` [Qemu-devel] [PATCH v2 1/2] mirror: fix dead-lock Vladimir Sementsov-Ogievskiy
2018-11-30 12:36 ` Max Reitz
2018-11-29 10:18 ` [Qemu-devel] [PATCH v2 2/2] iotests: simple mirror test with kvm on 1G image Vladimir Sementsov-Ogievskiy
2018-11-30 12:19 ` Kevin Wolf [this message]
2018-11-30 12:30 ` Max Reitz
2018-11-30 13:06 ` Vladimir Sementsov-Ogievskiy
2018-11-30 13:13 ` Max Reitz
2018-11-30 13:48 ` Vladimir Sementsov-Ogievskiy
2018-11-30 14:10 ` Kevin Wolf
2018-11-30 14:51 ` Vladimir Sementsov-Ogievskiy
2018-11-30 14:59 ` Max Reitz
2018-11-30 15:24 ` Vladimir Sementsov-Ogievskiy
2018-11-30 15:33 ` Max Reitz
2018-11-30 16:14 ` Vladimir Sementsov-Ogievskiy
2018-11-30 12:33 ` Max Reitz
2018-11-29 14:14 ` [Qemu-devel] [Qemu-devel for-3.1?] [PATCH v2 0/2] mirror dead-lock Eric Blake
2018-11-30 12:52 ` Max Reitz
2018-12-03 13:59 ` [Qemu-devel] " Max Reitz
2018-12-03 14:13 ` Vladimir Sementsov-Ogievskiy
2018-12-03 14:26 ` Max Reitz
2018-12-03 17:06 ` Eric Blake
2018-12-03 15:07 ` Peter Maydell
2018-12-03 16:06 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130121947.GD5106@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=dplotnikov@virtuozzo.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.