From: Andrew Lunn <andrew@lunn.ch>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: gerg@kernel.org, sean.wang@mediatek.com,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, blogic@openwrt.org, neil@brown.name,
"René van Dorst" <opensource@vdorst.com>
Subject: Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC
Date: Fri, 30 Nov 2018 14:42:40 +0100 [thread overview]
Message-ID: <20181130134240.GD11747@lunn.ch> (raw)
In-Reply-To: <87r2f2pxpa.fsf@miraculix.mork.no>
> > 1. TX packets are not getting an IP header checksum via the normal
> > off-loaded checksumming when in DSA mode. I have to switch off
> > NETIF_F_IP_CSUM, so the software stack generates the checksum.
> > That checksum offloading works ok when not using the 7530 DSA driver.
>
> Hmm. How do I test this?
If there are no IP checksums in the frame, the receiver will generally
drop the packet.
ethtool -k will show you what features the MAC has in terms of
offloading. So if you see NETIF_F_IP_CSUM, you know the MAC should be
doing it in hardware.
Andrew
next prev parent reply other threads:[~2018-12-01 0:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 7:57 [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC gerg
2018-11-30 7:57 ` [PATCH 1/3] net: dsa: mt7530: make clock/regulator setup optional gerg
2018-11-30 7:57 ` [PATCH 2/3] net: dsa: mt7530: optional setting CPU field in MFC register gerg
2018-11-30 7:57 ` [PATCH 3/3] dt-bindings: net: dsa: add new bindings MT7530 gerg
2018-11-30 17:41 ` Florian Fainelli
2018-12-03 7:03 ` Greg Ungerer
2018-12-03 13:19 ` Andrew Lunn
2018-11-30 11:27 ` [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC René van Dorst
2018-11-30 13:25 ` Greg Ungerer
2018-11-30 11:30 ` René van Dorst
2018-11-30 12:16 ` Bjørn Mork
2018-11-30 13:41 ` Greg Ungerer
2018-11-30 13:42 ` Andrew Lunn [this message]
2018-12-03 7:20 ` Greg Ungerer
2018-12-03 11:34 ` Bjørn Mork
2018-12-03 14:00 ` René van Dorst
2018-12-03 14:02 ` John Crispin
2018-12-07 7:12 ` Greg Ungerer
2018-12-04 7:23 ` Greg Ungerer
2018-12-11 5:02 ` NeilBrown
2018-12-11 8:28 ` Bjørn Mork
2018-12-16 22:08 ` NeilBrown
2018-12-16 22:14 ` David Miller
2018-12-16 23:19 ` NeilBrown
2018-12-17 0:00 ` Florian Fainelli
2018-12-17 7:11 ` NeilBrown
2018-11-30 13:33 ` Andrew Lunn
2018-12-03 6:47 ` Greg Ungerer
2018-11-30 13:37 ` Andrew Lunn
2018-11-30 13:45 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130134240.GD11747@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=blogic@openwrt.org \
--cc=f.fainelli@gmail.com \
--cc=gerg@kernel.org \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.