Re: [PATCH v4 1/7] target: use consistent left-aligned ASCII INQUIRY data

[David Disseldorp <ddiss@suse.de>]

On Wed, 28 Nov 2018 17:23:07 -0800, Lee Duncan wrote:

> > +	 * unused bytes at the end of the field (i.e., highest offset) and the
> > +	 * unused bytes shall be filled with ASCII space characters (20h).
> > +	 */
> > +	memset(&buf[8], 0x20, 8 + 16 + 4);  
> 
> I dislike that you are using 0x20 here (and below) instead of ' '.

Given that this patch already has a couple of reviewed-bys, I'd prefer
to avoid respinning it for this. Besides, I think the comment above
makes it pretty clear.

Thanks for your feedback.

Cheers, David