From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: leo.yan@linaro.org
Cc: Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>
Subject: Re: [PATCH] perf evsel: Correct clock unit to nanosecond
Date: Fri, 30 Nov 2018 12:25:21 -0300 [thread overview]
Message-ID: <20181130152521.GA10748@kernel.org> (raw)
In-Reply-To: <20181130142140.GB11833@leoy-ThinkPad-X240s>
Em Fri, Nov 30, 2018 at 10:21:40PM +0800, leo.yan@linaro.org escreveu:
> On Fri, Nov 30, 2018 at 11:21:54AM +0100, Jiri Olsa wrote:
> > On Fri, Nov 30, 2018 at 06:06:05PM +0800, Leo Yan wrote:
> > > Since commit 0aa802a79469 ("perf stat: Get rid of extra clock display
> > > function"), the cpu and task clock unit has been changed from
> > > nanosecond value to millisecond value. This introduces confusion for
> > > CPU run time statistics, we can see in below flow the clock value is
> > > scaled from nanosecond value to millisecond value; but this is
> > > contradiction with statistics type 'STAT_NSECS', which always takes
> > > clock as nanosecond unit.
>
> [...]
>
> > there was fix for this recently, could you please check
> > if it's working for you:
> > 6e269c85dcea perf stat: Fix shadow stats for clock events
>
> Ah, I missed this patch ...
>
> Yeah, I tested this patch and can confirm this patch fixes
> this issue.
My fault, new notebook update process got in the way causing
acme/perf/core to pile up, a perf/core pull req is about to be sent to
Ingo now tho :-)
- Arnaldo
next prev parent reply other threads:[~2018-11-30 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 10:06 [PATCH] perf evsel: Correct clock unit to nanosecond Leo Yan
2018-11-30 10:21 ` Jiri Olsa
2018-11-30 14:21 ` leo.yan
2018-11-30 15:25 ` Arnaldo Carvalho de Melo [this message]
2018-12-03 0:58 ` leo.yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130152521.GA10748@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=daniel.thompson@linaro.org \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.