From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 0/3] per-cpu in_flight counters for bio-based drivers Date: Fri, 30 Nov 2018 10:50:54 -0500 Message-ID: <20181130155054.GA13744@redhat.com> References: <20181128004211.368810060@debian.vm> <20181130144343.GA13483@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181130144343.GA13483@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: Jens Axboe , linux-block@vger.kernel.org, dm-devel@redhat.com, "Alasdair G. Kergon" , Christoph Hellwig List-Id: dm-devel.ids On Fri, Nov 30 2018 at 9:43am -0500, Mike Snitzer wrote: > On Tue, Nov 27 2018 at 7:42pm -0500, > Mikulas Patocka wrote: > > > These are the patches for per-cpu in_flight counters. > > Do you have updated before vs after performance results for these > changes? > > I'd imagine they are comparable to your previous run (though that run > included some other DM changes that I already staged). Would like to see before vs after with: http://git.kernel.dk/cgit/linux-block/log/?h=for-4.21/block vs https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=block-dm-4.21-inflight (block-dm-4.21-inflight is based on latest for-4.21/block -- and it contains DM changes in front of the block changes from this thread; I'd prefer Jens take the changes like this rather than leave DM in a bit of a mess for me/us to have to cleanup later) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B09FC04EB8 for ; Fri, 30 Nov 2018 15:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20FE920867 for ; Fri, 30 Nov 2018 15:50:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20FE920867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726771AbeLADAn (ORCPT ); Fri, 30 Nov 2018 22:00:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbeLADAn (ORCPT ); Fri, 30 Nov 2018 22:00:43 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A73189AC4; Fri, 30 Nov 2018 15:50:58 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 904E95F724; Fri, 30 Nov 2018 15:50:55 +0000 (UTC) Date: Fri, 30 Nov 2018 10:50:54 -0500 From: Mike Snitzer To: Mikulas Patocka Cc: Jens Axboe , dm-devel@redhat.com, linux-block@vger.kernel.org, "Alasdair G. Kergon" , Christoph Hellwig Subject: Re: [PATCH 0/3] per-cpu in_flight counters for bio-based drivers Message-ID: <20181130155054.GA13744@redhat.com> References: <20181128004211.368810060@debian.vm> <20181130144343.GA13483@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130144343.GA13483@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 30 Nov 2018 15:50:58 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Nov 30 2018 at 9:43am -0500, Mike Snitzer wrote: > On Tue, Nov 27 2018 at 7:42pm -0500, > Mikulas Patocka wrote: > > > These are the patches for per-cpu in_flight counters. > > Do you have updated before vs after performance results for these > changes? > > I'd imagine they are comparable to your previous run (though that run > included some other DM changes that I already staged). Would like to see before vs after with: http://git.kernel.dk/cgit/linux-block/log/?h=for-4.21/block vs https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=block-dm-4.21-inflight (block-dm-4.21-inflight is based on latest for-4.21/block -- and it contains DM changes in front of the block changes from this thread; I'd prefer Jens take the changes like this rather than leave DM in a bit of a mess for me/us to have to cleanup later)