From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org, osandov@osandov.com
Subject: [PATCHSET v4] sbitmap optimizations
Date: Fri, 30 Nov 2018 09:01:16 -0700 [thread overview]
Message-ID: <20181130160118.24683-1-axboe@kernel.dk> (raw)
This versions tests out solid, and we're still seeing the same
improvements.
Changes:
- Lock map index for the move. This eliminates the race completely,
since it's now not possible to find ->cleared == 0 while swap of
bits is in progress. The previous version was fine for users that
re-check after having added themselves to the waitqueue, but we
have users that don't re-check after getting failure. This works
for both.
- Add the new states to the blk-mq debugfs output.
- Wrap the waitqueue in a sbitmap waitqueue, so we can ensure that
we account it properly. This means that any kind of prep+finish
on the waitqueue will work fine, just like before.
--
Jens Axboe
next reply other threads:[~2018-11-30 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 16:01 Jens Axboe [this message]
2018-11-30 16:01 ` [PATCH 1/2] sbitmap: ammortize cost of clearing bits Jens Axboe
2018-11-30 20:03 ` Omar Sandoval
2018-11-30 20:10 ` Jens Axboe
2018-11-30 21:41 ` Omar Sandoval
2018-11-30 16:01 ` [PATCH 2/2] sbitmap: optimize wakeup check Jens Axboe
2018-11-30 21:37 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130160118.24683-1-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.