Re: [PATCH 2/3] coex: coex agent implementation

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]

Hi!

> +	dbus_message_iter_init_append(reply, &iter);
> +
> +	dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY,
> +					OFONO_PROPERTIES_ARRAY_SIGNATURE,
> +					&dict);
> +
> +	value = coex->bt_active;
> +	ofono_dbus_dict_append(&dict, "BTActive",
> +								DBUS_TYPE_BOOLEAN, &value);
> +
> +	value = coex->wlan_active;
> +	ofono_dbus_dict_append(&dict, "WLANActive",
> +								DBUS_TYPE_BOOLEAN, &value);
> +
> +	band = ofono_wlan_bw_to_string(coex->wlan_bw);
> +	ofono_dbus_dict_append(&dict, "WLANBandwidth",
> +									DBUS_TYPE_STRING, &band);


Something wrong with tabs here?

> +	if (coex->bt_active != coex->pending_bt_active) {
> +		coex->bt_active = coex->pending_bt_active;
> +		ofono_dbus_signal_property_changed(conn, path,
> +						OFONO_COEX_INTERFACE,
> +						"BTActive",
> +						DBUS_TYPE_BOOLEAN,
> +						&(coex->bt_active));
> +	}

Could probably be reformatted to fit on less lines.

> +	g_at_result_iter_init(&iter, result);
> +
> +	if (!g_at_result_iter_next(&iter, "+XNRTCWSW:"))
> +		return;
> +
> +	g_at_result_iter_next_number(&iter, &wlan.safe_rx_min);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_next_number(&iter, &wlan.safe_rx_max);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_next_number(&iter, &wlan.safe_tx_min);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_next_number(&iter, &wlan.safe_tx_max);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_skip_next(&iter);
> +
> +	g_at_result_iter_next_number(&iter, &wlan.num_safe_vector);

Making every second line empty does not really help readability...

									Pavel
									
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]