From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joey Pabalinas Subject: Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0 Date: Fri, 30 Nov 2018 15:20:27 -1000 Message-ID: <20181201012027.huph7f5wbvref3di@gmail.com> References: <20181130233221.8433-1-joe@wand.net.nz> <20181201003657.kljfgwgxkf66rpdb@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f6wijcuyzfnallnc" To: Joey Pabalinas , Joe Stringer , daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, dsahern@gmail.com, nicolas.dichtel@6wind.com Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:34860 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbeLAMbq (ORCPT ); Sat, 1 Dec 2018 07:31:46 -0500 Received: by mail-pf1-f193.google.com with SMTP id z9so3635353pfi.2 for ; Fri, 30 Nov 2018 17:20:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181201003657.kljfgwgxkf66rpdb@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: --f6wijcuyzfnallnc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 30, 2018 at 02:36:57PM -1000, Joey Pabalinas wrote: > On Fri, Nov 30, 2018 at 03:32:20PM -0800, Joe Stringer wrote: > > + * the netns associated with the *ctx*. *netns* values beyond the > > + * range of 32-bit integers are reserved for future use. >=20 > Would adding a word or two before "*netns*" here be helpful to placate > the english pedants among us (such as myself)? Starting a sentence with > a lowercase word, even if it's a variable name, just never really sits > right with me. >=20 > Any *netns* values ... >=20 > Doesn't that kind of flow a bit better anyway? Hah, > Anyway, now with that unimportant nitpick if off my chest, the rest ^ | I make an absolutely terrible pedant. ------ --=20 Cheers, Joey Pabalinas --f6wijcuyzfnallnc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlwB4doACgkQ2rGdfm9D tVIHZw/+OVwXt+FrvXZaV2eMHmMniHXK4EqW5b6wLS8FUBT/5obsYOTLIc3osBn2 1iizspW3xrUhB2FaebtWMTIi/HfeI+xRVc31VrSolH/mVOZp4pie/4RVG7Sr7yfZ SivDpN+N33xMoH8ZBbQS/OefoRgRLjVKBCsbX6l7X1qv3CjjB6ru2KJf5APQMbi/ jQptZzD/NExGoNygAPtqlbKMAe0x9vv24lyADRDFexijVrkMtwUXcFzjRAWWuHo3 ZYyCDwL68Q09V/N1D204Y/Laolcffrfu/5hdsbP37nfnijCtXMRDm6vTwuFK+Tk2 9BSvX411zmI2pwdQMhWTzkY308KPcSpFzIEhEv4fHxMyLaAGW2Ud2w+/O9apfvjN 2CbBPQaTov6iE0z2C74R8r79CvGEmeYjW+4VUt9DJOjA+p7lqSQ9D67ZYveU2Q4X bh8/ZlC//glBk/dim1cFDgneUCC9ObTuRK6sBG4kod538jMt1wy/+AAv61MCi0Y8 egYQylRWXqQt4XZGVk6cOyUbHc2afvtHj+sIfpdKiXx9ei/1nMfobxOWt3IOs+m6 r2OeNeM4RxjB/tjgFFgcj9wPEcVVZRDf8L7YQUChXAdve+rVzYb9PGdhcs75Ibpw fkIR8+4mn1D3NLzta3xYMG9vl2fuiAyB5mizTZ6FOg8T9HuGPko= =V+S6 -----END PGP SIGNATURE----- --f6wijcuyzfnallnc--