From: Pavel Machek <pavel@ucw.cz>
To: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org
Cc: kernel list <linux-kernel@vger.kernel.org>,
kvalo@codeaurora.org, davem@davemloft.net,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c
Date: Sat, 1 Dec 2018 15:31:44 +0100 [thread overview]
Message-ID: <20181201143144.GC31631@amd> (raw)
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
Hi!
While grepping something else, I came across LED trigger that is named
just "tx".
That's a bit too generic afaict?
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device
*udev, u8 *buf, u32 size,
static int tx_activity;
static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);
static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc);
-DEFINE_LED_TRIGGER(ledtrig_tx);
+DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic
name for a trigger! */
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next reply other threads:[~2018-12-01 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 14:31 Pavel Machek [this message]
2018-12-03 8:45 ` trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c Kalle Valo
2018-12-09 20:08 ` Pavel Machek
2018-12-10 17:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201143144.GC31631@amd \
--to=pavel@ucw.cz \
--cc=davem@davemloft.net \
--cc=jacek.anaszewski@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.