From: Greg KH <gregkh@linuxfoundation.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, Guangwu Zhang <guazhang@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Jianchao Wang <jianchao.w.wang@oracle.com>
Subject: Re: [PATCH] block: fix single range discard merge
Date: Sun, 2 Dec 2018 08:32:14 +0100 [thread overview]
Message-ID: <20181202073214.GB31761@kroah.com> (raw)
In-Reply-To: <1543599056.4347.11.camel@acm.org>
On Fri, Nov 30, 2018 at 09:30:56AM -0800, Bart Van Assche wrote:
> On Fri, 2018-11-30 at 10:20 -0700, Jens Axboe wrote:
> > On 11/30/18 10:18 AM, Bart Van Assche wrote:
> > > On Sat, 2018-12-01 at 00:38 +0800, Ming Lei wrote:
> > > > Fixes: 445251d0f4d329a ("blk-mq: fix discard merge with scheduler attached")
> > >
> > > Since this patch fixes a bug introduced in kernel v4.16, does it need
> > > a "Cc: stable" tag?
> >
> > Like the other one, isn't stable implied with Fixes in there? You'd want
> > a stable backport for any kernel that has that patchset. I think that's
> > a stronger hint than stable cc.
>
> (+Greg KH)
>
> Hi Greg,
>
> Would it be possible to clarify what your preferences are for adding a
> "Cc: stable" tag?
Doesn't:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
describe it well enough?
Hint, putting a "Fixes:" only tag on a patch is nice, but will not
guarantee it will end up in the stable tree. Only a "Cc: stable@..."
tag will. Putting both on, if you know the fixes commit, is the best.
thanks,
greg k-h
next prev parent reply other threads:[~2018-12-02 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 16:38 [PATCH] block: fix single range discard merge Ming Lei
2018-11-30 17:10 ` Jens Axboe
2018-11-30 17:18 ` Bart Van Assche
2018-11-30 17:20 ` Jens Axboe
2018-11-30 17:30 ` Bart Van Assche
2018-12-02 7:32 ` Greg KH [this message]
2018-11-30 17:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181202073214.GB31761@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=guazhang@redhat.com \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.