From: Jerome Glisse <jglisse@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au,
dan.j.williams@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
Date: Mon, 03 Dec 2018 00:48:49 +0000 [thread overview]
Message-ID: <20181203004848.GA21092@redhat.com> (raw)
In-Reply-To: <1543629971-128377-1-git-send-email-yuehaibing@huawei.com>
On Sat, Dec 01, 2018 at 02:06:11AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au,
dan.j.williams@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
Date: Sun, 2 Dec 2018 19:48:49 -0500 [thread overview]
Message-ID: <20181203004848.GA21092@redhat.com> (raw)
In-Reply-To: <1543629971-128377-1-git-send-email-yuehaibing@huawei.com>
On Sat, Dec 01, 2018 at 02:06:11AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: J�r�me Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au,
dan.j.williams@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
Date: Sun, 2 Dec 2018 19:48:49 -0500 [thread overview]
Message-ID: <20181203004848.GA21092@redhat.com> (raw)
In-Reply-To: <1543629971-128377-1-git-send-email-yuehaibing@huawei.com>
On Sat, Dec 01, 2018 at 02:06:11AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
next prev parent reply other threads:[~2018-12-03 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 1:57 [PATCH -next] mm/hmm: remove set but not used variable 'devmem' YueHaibing
2018-12-01 2:06 ` YueHaibing
2018-12-01 2:06 ` YueHaibing
2018-12-03 0:48 ` Jerome Glisse [this message]
2018-12-03 0:48 ` Jerome Glisse
2018-12-03 0:48 ` Jerome Glisse
2018-12-03 11:11 ` David Hildenbrand
2018-12-03 11:11 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203004848.GA21092@redhat.com \
--to=jglisse@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.