From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dave Rodgman <dave.rodgman@arm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, nd <nd@arm.com>
Subject: Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo
Date: Mon, 3 Dec 2018 11:40:19 +0900 [thread overview]
Message-ID: <20181203024019.GB427@jagdpanzerIV> (raw)
In-Reply-To: <5b504430-fb4b-340b-66c2-1300c816cc3a@arm.com>
On (11/30/18 10:45), Dave Rodgman wrote:
> Looking a bit more closely, these structs are formatted fairly
> inconsistently in the crypto directory. So, lzo-rle is consistent with
> what lzo does... but various other files do it differently.
>
> I'm happy to submit a whitespace cleanup patch if people would like, and
> get everything in that directory consistent (i.e. adopt a style similar
> to the example below)?
I'm not in any position to ask you to do this; white-space clean ups
are not very popular (it's OK for staging tree; not so much otherwise).
So we better ask David and Herbert.
> static struct scomp_alg scomp = {
> .alloc_ctx = lzorle_alloc_ctx,
> .free_ctx = lzorle_free_ctx,
> .compress = lzorle_scompress,
> .decompress = lzorle_sdecompress,
> .base = {
> .cra_name = "lzo-rle",
> .cra_driver_name = "lzo-rle-scomp",
> .cra_module = THIS_MODULE,
> }
> };
Looks nice.
-ss
next prev parent reply other threads:[~2018-12-03 2:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:19 [PATCH v2 0/7] lib/lzo: performance improvements Dave Rodgman
2018-11-27 16:19 ` [PATCH 1/7] lib/lzo: tidy-up ifdefs Dave Rodgman
2018-11-27 16:19 ` [PATCH 2/7] lib/lzo: clean-up by introducing COPY16 Dave Rodgman
2018-11-27 22:50 ` Andrew Morton
2018-11-27 16:19 ` [PATCH 3/7] lib/lzo: enable 64-bit CTZ on Arm Dave Rodgman
2018-11-27 16:19 ` [PATCH 5/7] lib/lzo: fast 8-byte copy on arm64 Dave Rodgman
2018-11-27 16:19 ` [PATCH 4/7] lib/lzo: 64-bit CTZ " Dave Rodgman
2018-11-27 16:19 ` [PATCH 6/7] lib/lzo: implement run-length encoding Dave Rodgman
2018-11-29 3:08 ` Sergey Senozhatsky
2018-11-29 3:11 ` Sergey Senozhatsky
2018-11-27 16:19 ` [PATCH 7/7] lib/lzo: separate lzo-rle from lzo Dave Rodgman
2018-11-29 4:43 ` Sergey Senozhatsky
2018-11-29 10:21 ` Dave Rodgman
2018-11-29 20:32 ` Andrew Morton
2018-11-30 3:05 ` Sergey Senozhatsky
2018-11-30 10:45 ` Dave Rodgman
2018-12-03 2:40 ` Sergey Senozhatsky [this message]
2018-12-03 2:53 ` Herbert Xu
2018-11-29 4:46 ` [PATCH v2 0/7] lib/lzo: performance improvements Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203024019.GB427@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=dave.rodgman@arm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.