From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Avri.Altman@wdc.com
Subject: Re: [PATCH] mmc: document 'Reliable Write' bit in uapi header
Date: Mon, 3 Dec 2018 17:15:11 +0100 [thread overview]
Message-ID: <20181203161511.GA1604@kunai> (raw)
In-Reply-To: <CAMuHMdX+skNFbUiCjzU=vuR3PfTFib5ad+C1yDp=Kc6i2A=Hyw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, Geert!
> > - /* Implies direction of data. true = write, false = read */
> > + /*
> > + * Implies direction of data. true = write, false = read.
>
> nonzero = write, zero = read?
Yes, even better. Will update.
> > + * Bit 31 selects 'Reliable Write' for RPMB.
>
> Perhaps having a #define for this would be nice?
> Can also be used by the driver, instead of 1 << 31, which some static
> analyzers may complain about.
Maybe. Should be an incremental patch then, I'd say.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-12-03 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 14:26 [PATCH] mmc: document 'Reliable Write' bit in uapi header Wolfram Sang
2018-12-03 15:00 ` Geert Uytterhoeven
2018-12-03 16:15 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203161511.GA1604@kunai \
--to=wsa@the-dreams.de \
--cc=Avri.Altman@wdc.com \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.