From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings Date: Mon, 3 Dec 2018 13:47:05 -0700 Message-ID: <20181203204705.GE12237@ziepe.ca> References: <201811280723.DnTk8AXL%fengguang.wu@intel.com> <20181127232130.GA28456@sof-kbuild01> <20181129233721.GA11172@ziepe.ca> <51cb9d8e7b107d37447b9e0d218bb12d8cf49ebb.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <51cb9d8e7b107d37447b9e0d218bb12d8cf49ebb.camel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Doug Ledford Cc: kbuild test robot , kbuild-all@01.org, Leon Romanovsky , Yishai Hadas , Mark Bloch , Ariel Levkovich , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On Mon, Dec 03, 2018 at 12:23:35PM -0500, Doug Ledford wrote: > On Thu, 2018-11-29 at 16:37 -0700, Jason Gunthorpe wrote: > > On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote: > > > From: kbuild test robot > > > > > > drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > > > > > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > > > > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > > > > > Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success") > > > Signed-off-by: kbuild test robot > > > > applied to for-next, thanks > > > > Jason > > This caused a conflict with your make write() handlers use a consistent > flow series, which I fixed up during git am run. Just FYI in case you > want to check out the conflict spot as a double check (but it was a > simple fixup). Looks OK to me thanks Jason