From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB4AC04EB9 for ; Mon, 3 Dec 2018 22:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38EDB20851 for ; Mon, 3 Dec 2018 22:18:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38EDB20851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725893AbeLCWS6 convert rfc822-to-8bit (ORCPT ); Mon, 3 Dec 2018 17:18:58 -0500 Received: from mail.bootlin.com ([62.4.15.54]:34451 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbeLCWS6 (ORCPT ); Mon, 3 Dec 2018 17:18:58 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id C9D6620791; Mon, 3 Dec 2018 23:18:55 +0100 (CET) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id BDCEC207AD; Mon, 3 Dec 2018 23:18:44 +0100 (CET) Date: Mon, 3 Dec 2018 23:18:44 +0100 From: Miquel Raynal To: "Rafael J. Wysocki" Cc: Lorenzo Pieralisi , sudeep.holla@arm.com, Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas , devicetree@vger.kernel.org, Rob Herring , Mark Rutland , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Antoine Tenart , Maxime Chevallier , Nadav Haklai Subject: Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support Message-ID: <20181203231844.0791bdee@xps13> In-Reply-To: <1999610.6DN9RK2Tt3@aspire.rjw.lan> References: <20181123141831.8214-1-miquel.raynal@bootlin.com> <20181203102708.GA6090@e107981-ln.cambridge.arm.com> <20181203163846.494904f9@xps13> <1999610.6DN9RK2Tt3@aspire.rjw.lan> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Rafael, Stephen, "Rafael J. Wysocki" wrote on Mon, 03 Dec 2018 23:00:20 +0100: > On Monday, December 3, 2018 4:38:46 PM CET Miquel Raynal wrote: > > Hi Lorenzo, > > > > Lorenzo Pieralisi wrote on Mon, 3 Dec 2018 > > 10:27:08 +0000: > > > > > [+Rafael, Sudeep] > > > > > > On Fri, Nov 23, 2018 at 03:18:24PM +0100, Miquel Raynal wrote: > > > > Add suspend and resume callbacks. The priority of these are > > > > "_noirq()", to workaround early access to the registers done by the > > > > PCI core through the ->read()/->write() callbacks at resume time. > > > > > > > > Signed-off-by: Miquel Raynal > > > > --- > > > > drivers/pci/controller/pci-aardvark.c | 52 +++++++++++++++++++++++++++ > > > > 1 file changed, 52 insertions(+) > > > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > > > index 108b3f15c410..7ecf1ac4036b 100644 > > > > --- a/drivers/pci/controller/pci-aardvark.c > > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > > @@ -1108,6 +1108,55 @@ static int advk_pcie_setup_clk(struct advk_pcie *pcie) > > > > return ret; > > > > } > > > > > > > > +static int __maybe_unused advk_pcie_suspend(struct device *dev) > > > > +{ > > > > + struct advk_pcie *pcie = dev_get_drvdata(dev); > > > > + > > > > + advk_pcie_disable_phy(pcie); > > > > + > > > > + clk_disable_unprepare(pcie->clk); > > > > > > I have noticed it is common practice, still, I would like to check whether > > > it is allowed to call functions that may sleep in a NOIRQ suspend/resume > > > callback ? > > > > You are right this is weird. I double checked and for instance, > > pcie-mediatek.c, pci-tegra.c and pci-imx6.c do the exact same thing. There are > > probably other cases where drivers call functions that may sleep from a NOIRQ > > context. I am interested to know if this is valid and if not, what is the > > alternative? > > > > Yes, it is valid. _noirq means that the high-level action handlers will not be > invoked for interrupts occurring during that period, but that doesn't apply to > timer interrupts. > > IOW, don't expect *your* IRQ handler to be invoked then (if this is not a timer > IRQ), but you can sleep. > > Thanks, > Rafael > Thank you both for the enlightenment. Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A354C04EB9 for ; Mon, 3 Dec 2018 22:19:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B15C20851 for ; Mon, 3 Dec 2018 22:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bDQJnXSk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B15C20851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cSK47XMsd7BstWV1twuDRHX4WcxbmeapqntCNBoBf2I=; b=bDQJnXSkUp1ehd gGnB1dWtFpB70PvS5za8IkJonv2jzgJyAnW1Lr19QOjTZx5WSUl3n3BaKyFHUs9CnGu/ijQv8c6yw /cQz9TQLnh4GTOFYNerg66OhcylPss4WBVBiyBh11kuNfz/5FHTVR/kUQ/BocsS7K4Vy5Msb4Qwsw xvXeh1Zp9+7KwAEdQkr/88YwKBrYCT+E5UBMIVowtfNbiEYEUJXGrTUdAm5ZPvI+8bnO+Aqr1RESL 4F7XzWB0bquVqOhSQz+5b3thzciHAiV09VgaBW+EezWcGqRXri6JS5ZuCBsEbE6HbwYa2gWsSE2J4 6fl1fRNuYyO4ARcghb/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTwYY-0001M9-JK; Mon, 03 Dec 2018 22:19:10 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTwYV-0001Ks-0D for linux-arm-kernel@lists.infradead.org; Mon, 03 Dec 2018 22:19:08 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id C9D6620791; Mon, 3 Dec 2018 23:18:55 +0100 (CET) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id BDCEC207AD; Mon, 3 Dec 2018 23:18:44 +0100 (CET) Date: Mon, 3 Dec 2018 23:18:44 +0100 From: Miquel Raynal To: "Rafael J. Wysocki" Subject: Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support Message-ID: <20181203231844.0791bdee@xps13> In-Reply-To: <1999610.6DN9RK2Tt3@aspire.rjw.lan> References: <20181123141831.8214-1-miquel.raynal@bootlin.com> <20181203102708.GA6090@e107981-ln.cambridge.arm.com> <20181203163846.494904f9@xps13> <1999610.6DN9RK2Tt3@aspire.rjw.lan> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181203_141907_316246_D4482371 X-CRM114-Status: GOOD ( 23.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , linux-pci@vger.kernel.org, Gregory Clement , linux-kernel@vger.kernel.org, Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , sudeep.holla@arm.com, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUmFmYWVsLCBTdGVwaGVuLAoKIlJhZmFlbCBKLiBXeXNvY2tpIiA8cmp3QHJqd3lzb2NraS5u ZXQ+IHdyb3RlIG9uIE1vbiwgMDMgRGVjIDIwMTgKMjM6MDA6MjAgKzAxMDA6Cgo+IE9uIE1vbmRh eSwgRGVjZW1iZXIgMywgMjAxOCA0OjM4OjQ2IFBNIENFVCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ ID4gSGkgTG9yZW56bywKPiA+IAo+ID4gTG9yZW56byBQaWVyYWxpc2kgPGxvcmVuem8ucGllcmFs aXNpQGFybS5jb20+IHdyb3RlIG9uIE1vbiwgMyBEZWMgMjAxOAo+ID4gMTA6Mjc6MDggKzAwMDA6 Cj4gPiAgIAo+ID4gPiBbK1JhZmFlbCwgU3VkZWVwXQo+ID4gPiAKPiA+ID4gT24gRnJpLCBOb3Yg MjMsIDIwMTggYXQgMDM6MTg6MjRQTSArMDEwMCwgTWlxdWVsIFJheW5hbCB3cm90ZTogIAo+ID4g PiA+IEFkZCBzdXNwZW5kIGFuZCByZXN1bWUgY2FsbGJhY2tzLiBUaGUgcHJpb3JpdHkgb2YgdGhl c2UgYXJlCj4gPiA+ID4gIl9ub2lycSgpIiwgdG8gd29ya2Fyb3VuZCBlYXJseSBhY2Nlc3MgdG8g dGhlIHJlZ2lzdGVycyBkb25lIGJ5IHRoZQo+ID4gPiA+IFBDSSBjb3JlIHRocm91Z2ggdGhlIC0+ cmVhZCgpLy0+d3JpdGUoKSBjYWxsYmFja3MgYXQgcmVzdW1lIHRpbWUuCj4gPiA+ID4gCj4gPiA+ ID4gU2lnbmVkLW9mZi1ieTogTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNv bT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZh cmsuYyB8IDUyICsrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ICAxIGZpbGUgY2hh bmdlZCwgNTIgaW5zZXJ0aW9ucygrKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9wY2ktYWFyZHZhcmsuYwo+ID4gPiA+IGluZGV4IDEwOGIzZjE1YzQxMC4uN2VjZjFhYzQwMzZi IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJr LmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCj4g PiA+ID4gQEAgLTExMDgsNiArMTEwOCw1NSBAQCBzdGF0aWMgaW50IGFkdmtfcGNpZV9zZXR1cF9j bGsoc3RydWN0IGFkdmtfcGNpZSAqcGNpZSkKPiA+ID4gPiAgCXJldHVybiByZXQ7Cj4gPiA+ID4g IH0KPiA+ID4gPiAgCj4gPiA+ID4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgYWR2a19wY2ll X3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ID4gPiA+ICt7Cj4gPiA+ID4gKwlzdHJ1Y3Qg YWR2a19wY2llICpwY2llID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gPiA+ID4gKwo+ID4gPiA+ ICsJYWR2a19wY2llX2Rpc2FibGVfcGh5KHBjaWUpOwo+ID4gPiA+ICsKPiA+ID4gPiArCWNsa19k aXNhYmxlX3VucHJlcGFyZShwY2llLT5jbGspOyAgICAKPiA+ID4gCj4gPiA+IEkgaGF2ZSBub3Rp Y2VkIGl0IGlzIGNvbW1vbiBwcmFjdGljZSwgc3RpbGwsIEkgd291bGQgbGlrZSB0byBjaGVjayB3 aGV0aGVyCj4gPiA+IGl0IGlzIGFsbG93ZWQgdG8gY2FsbCBmdW5jdGlvbnMgdGhhdCBtYXkgc2xl ZXAgaW4gYSBOT0lSUSBzdXNwZW5kL3Jlc3VtZQo+ID4gPiBjYWxsYmFjayA/ICAKPiA+IAo+ID4g WW91IGFyZSByaWdodCB0aGlzIGlzIHdlaXJkLiBJIGRvdWJsZSBjaGVja2VkIGFuZCBmb3IgaW5z dGFuY2UsCj4gPiBwY2llLW1lZGlhdGVrLmMsIHBjaS10ZWdyYS5jIGFuZCBwY2ktaW14Ni5jIGRv IHRoZSBleGFjdCBzYW1lIHRoaW5nLiBUaGVyZSBhcmUKPiA+IHByb2JhYmx5IG90aGVyIGNhc2Vz IHdoZXJlIGRyaXZlcnMgY2FsbCBmdW5jdGlvbnMgdGhhdCBtYXkgc2xlZXAgZnJvbSBhIE5PSVJR Cj4gPiBjb250ZXh0LiBJIGFtIGludGVyZXN0ZWQgdG8ga25vdyBpZiB0aGlzIGlzIHZhbGlkIGFu ZCBpZiBub3QsIHdoYXQgaXMgdGhlCj4gPiBhbHRlcm5hdGl2ZT8KPiA+ICAgCj4gCj4gWWVzLCBp dCBpcyB2YWxpZC4gIF9ub2lycSBtZWFucyB0aGF0IHRoZSBoaWdoLWxldmVsIGFjdGlvbiBoYW5k bGVycyB3aWxsIG5vdCBiZQo+IGludm9rZWQgZm9yIGludGVycnVwdHMgb2NjdXJyaW5nIGR1cmlu ZyB0aGF0IHBlcmlvZCwgYnV0IHRoYXQgZG9lc24ndCBhcHBseSB0bwo+IHRpbWVyIGludGVycnVw dHMuCj4gCj4gSU9XLCBkb24ndCBleHBlY3QgKnlvdXIqIElSUSBoYW5kbGVyIHRvIGJlIGludm9r ZWQgdGhlbiAoaWYgdGhpcyBpcyBub3QgYSB0aW1lcgo+IElSUSksIGJ1dCB5b3UgY2FuIHNsZWVw Lgo+IAo+IFRoYW5rcywKPiBSYWZhZWwKPiAKClRoYW5rIHlvdSBib3RoIGZvciB0aGUgZW5saWdo dGVubWVudC4KCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK