From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Artem Blagodarenko <artem.blagodarenko@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Fix tst_super_size after ext2_super_block changes
Date: Mon, 3 Dec 2018 21:25:16 -0500 [thread overview]
Message-ID: <20181204022516.GA32349@thunk.org> (raw)
In-Reply-To: <050FAC09-2437-417C-AF69-7637613BA7BB@dilger.ca>
On Wed, Nov 28, 2018 at 12:09:26PM -0700, Andreas Dilger wrote:
> On Nov 28, 2018, at 9:08 AM, Artem Blagodarenko <artem.blagodarenko@gmail.com> wrote:
> >
> > Commits "Reserve feature bit and SB field bit for filename encoding"
> > and "Add timestamp extension bits to superblock" change
> > ext2_super_block structure, but don't change tst_super_size test,
> > so "make check" fails with message:
> >
> > error: s_reserved size 380 should be 392
>
> How did these patches even land without "make check" being run once?
> Does this test failure not cause "make check" to fail?
My bad; I failed to run the make check before pushing it out. I fixed
this before seeing Artem's patch, and the fix was what he pushed out.
- Ted
prev parent reply other threads:[~2018-12-04 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:08 [PATCH] Fix tst_super_size after ext2_super_block changes Artem Blagodarenko
2018-11-28 19:09 ` Andreas Dilger
2018-12-04 2:25 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204022516.GA32349@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=artem.blagodarenko@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.