From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 2/2] lxc: fix build without stack protector
Date: Tue, 4 Dec 2018 09:10:29 +0100 [thread overview]
Message-ID: <20181204091029.01a78c0e@windsurf> (raw)
In-Reply-To: <20181204055439.rhfgmyb6w7ijykx6@sapphire.tkos.co.il>
Hello,
+Arnout, Peter, Yann in Cc.
On Tue, 4 Dec 2018 07:54:39 +0200, Baruch Siach wrote:
> > +LXC_CONF_ENV = ax_cv_check_cflags__Werror__fstack_protector_strong=no
>
> Can't we make this depend on BR2_TOOLCHAIN_HAS_SSP? See the packages ntp or
> sox, for example.
The question is whether we want SSP support to be enabled as soon as
the toolchain *has* SSP support, or only when the user explicitly
request SSP support using BR2_SSP_{REGULAR,STRONG,ALL} ?
This is a real policy decision:
- Do we let the packages default to what they think is good (of course
as long as the toolchain provides what's needed) ?
- Or do we enforce the system-level configuration options that
Buildroot has ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-04 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 22:38 [Buildroot] [PATCH v2,1/2] lxc: fix missing include for va_list Fabrice Fontaine
2018-12-03 22:38 ` [Buildroot] [PATCH v2,2/2] lxc: fix build without stack protector Fabrice Fontaine
2018-12-04 5:54 ` [Buildroot] [PATCH v2, 2/2] " Baruch Siach
2018-12-04 8:10 ` Thomas Petazzoni [this message]
2018-12-04 8:15 ` Baruch Siach
2018-12-04 8:31 ` Thomas Petazzoni
2018-12-04 8:39 ` Baruch Siach
2018-12-04 9:35 ` [Buildroot] Stack protector choices [was: [PATCH v2, 2/2] lxc: fix build without stack protector] Arnout Vandecappelle
2018-12-04 10:08 ` Thomas Petazzoni
2018-12-04 15:23 ` [Buildroot] [External] " Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204091029.01a78c0e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.