From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,09/12] usb: dwc3: Registering a role switch in the DRD code. From: Heikki Krogerus Message-Id: <20181204105416.GA10657@kuha.fi.intel.com> Date: Tue, 4 Dec 2018 12:54:16 +0200 To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Felipe Balbi , Greg Kroah-Hartman List-ID: T24gTW9uLCBEZWMgMDMsIDIwMTggYXQgMTE6NDU6MTJBTSArMDgwMCwgWXUgQ2hlbiB3cm90ZToK PiBUaGUgVHlwZS1DIGRyaXZlcnMgdXNlIFVTQiByb2xlIHN3aXRjaCBBUEkgdG8gaW5mb3JtIHRo ZQo+IHN5c3RlbSBhYm91dCB0aGUgbmVnb3RpYXRlZCBkYXRhIHJvbGUsIHNvIHJlZ2lzdGVyaW5n IGEgcm9sZQo+IHN3aXRjaCBpbiB0aGUgRFJEIGNvZGUgaW4gb3JkZXIgdG8gc3VwcG9ydCBwbGF0 Zm9ybXMgd2l0aAo+IFVTQiBUeXBlLUMgY29ubmVjdG9ycy4KPiAKPiBDYzogRmVsaXBlIEJhbGJp IDxiYWxiaUBrZXJuZWwub3JnPgo+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51 eGZvdW5kYXRpb24ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IFl1IENoZW4gPGNoZW55dTU2QGh1YXdl aS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSGVpa2tpIEtyb2dlcnVzIDxoZWlra2kua3JvZ2VydXNA bGludXguaW50ZWwuY29tPgo+IAo+IC0tCj4gdjA6Cj4gVGhlIHBhdGNoIGlzIHByb3ZpZGVkIGJ5 IEhlaWtraSBLcm9nZXJ1cy4gSSBtb2RpZmllZCBhbmQgdGVzdCBpdAo+IG9uIEhpa2V5OTYwIHBs YXRmb3JtLgo+IC0tCj4gLS0tCj4gIGRyaXZlcnMvdXNiL2R3YzMvY29yZS5oIHwgIDIgKysKPiAg ZHJpdmVycy91c2IvZHdjMy9kcmQuYyAgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNTEgaW5zZXJ0aW9ucygr KQoKWW91IG5lZWQgdG8gc2VsZWN0IFVTQl9ST0xFX1NXSVRDSCBpbiBLY29uZmlnOgoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvdXNiL2R3YzMvS2NvbmZpZyBiL2RyaXZlcnMvdXNiL2R3YzMvS2NvbmZp ZwppbmRleCAxYTA0MDRmZGE1OTYuLjNhMGNiOWYxZjM4YSAxMDA2NDQKLS0tIGEvZHJpdmVycy91 c2IvZHdjMy9LY29uZmlnCisrKyBiL2RyaXZlcnMvdXNiL2R3YzMvS2NvbmZpZwpAQCAtNDIsNiAr NDIsNyBAQCBjb25maWcgVVNCX0RXQzNfRFVBTF9ST0xFCiAgICAgICAgYm9vbCAiRHVhbCBSb2xl IG1vZGUiCiAgICAgICAgZGVwZW5kcyBvbiAoKFVTQj15IHx8IFVTQj1VU0JfRFdDMykgJiYgKFVT Ql9HQURHRVQ9eSB8fCBVU0JfR0FER0VUPVVTQl9EV0MzKSkKICAgICAgICBkZXBlbmRzIG9uIChF WFRDT049eSB8fCBFWFRDT049VVNCX0RXQzMpCisgICAgICAgc2VsZWN0IFVTQl9ST0xFX1NXSVRD SAogICAgICAgIGhlbHAKICAgICAgICAgIFRoaXMgaXMgdGhlIGRlZmF1bHQgbW9kZSBvZiB3b3Jr aW5nIG9mIERXQzMgY29udHJvbGxlciB3aGVyZQogICAgICAgICAgYm90aCBob3N0IGFuZCBnYWRn ZXQgZmVhdHVyZXMgYXJlIGVuYWJsZWQuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code. Date: Tue, 4 Dec 2018 12:54:16 +0200 Message-ID: <20181204105416.GA10657@kuha.fi.intel.com> References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-10-chenyu56@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181203034515.91412-10-chenyu56@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Felipe Balbi , Greg Kroah-Hartman List-Id: devicetree@vger.kernel.org On Mon, Dec 03, 2018 at 11:45:12AM +0800, Yu Chen wrote: > The Type-C drivers use USB role switch API to inform the > system about the negotiated data role, so registering a role > switch in the DRD code in order to support platforms with > USB Type-C connectors. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Signed-off-by: Yu Chen > Signed-off-by: Heikki Krogerus > > -- > v0: > The patch is provided by Heikki Krogerus. I modified and test it > on Hikey960 platform. > -- > --- > drivers/usb/dwc3/core.h | 2 ++ > drivers/usb/dwc3/drd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+) You need to select USB_ROLE_SWITCH in Kconfig: diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 1a0404fda596..3a0cb9f1f38a 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -42,6 +42,7 @@ config USB_DWC3_DUAL_ROLE bool "Dual Role mode" depends on ((USB=y || USB=USB_DWC3) && (USB_GADGET=y || USB_GADGET=USB_DWC3)) depends on (EXTCON=y || EXTCON=USB_DWC3) + select USB_ROLE_SWITCH help This is the default mode of working of DWC3 controller where both host and gadget features are enabled. -- heikki